* [PATCH] acer-wmi: set permissions on interface file to S_IRUGO
@ 2010-06-30 2:20 Axel Lin
2010-07-01 13:53 ` Matthew Garrett
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-06-30 2:20 UTC (permalink / raw)
To: linux-kernel
Cc: Carlos Corbacho, Matthew Garrett, Len Brown, Thomas Renninger,
platform-driver-x86
The interface file is not writable, thus set permissions to S_IRUGO.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/platform/x86/acer-wmi.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1415d97..fe7c9e4 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1084,8 +1084,7 @@ static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
}
}
-static DEVICE_ATTR(interface, S_IWUGO | S_IRUGO | S_IWUSR,
- show_interface, NULL);
+static DEVICE_ATTR(interface, S_IRUGO, show_interface, NULL);
/*
* debugfs functions
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] acer-wmi: set permissions on interface file to S_IRUGO
2010-06-30 2:20 [PATCH] acer-wmi: set permissions on interface file to S_IRUGO Axel Lin
@ 2010-07-01 13:53 ` Matthew Garrett
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Garrett @ 2010-07-01 13:53 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Carlos Corbacho, Len Brown, Thomas Renninger,
platform-driver-x86
On Wed, Jun 30, 2010 at 10:20:23AM +0800, Axel Lin wrote:
> The interface file is not writable, thus set permissions to S_IRUGO.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-01 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-30 2:20 [PATCH] acer-wmi: set permissions on interface file to S_IRUGO Axel Lin
2010-07-01 13:53 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox