From: Matthew Garrett <mjg@redhat.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Len Brown" <len.brown@intel.com>,
"Dmitry Torokhov" <dtor@mail.ru>,
"Márton Németh" <nm127@freemail.hu>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: fix a memory leak
Date: Thu, 1 Jul 2010 14:53:48 +0100 [thread overview]
Message-ID: <20100701135348.GF31804@srcf.ucam.org> (raw)
In-Reply-To: <1277889946.30827.2.camel@mola>
On Wed, Jun 30, 2010 at 05:25:46PM +0800, Axel Lin wrote:
> If dell_new_hk_type is true, dell_legacy_wmi_keymap will point to a memory
> allocated in setup_new_hk_map().
> In this case, the memory is not freed in current implementation.
> This patch fixes the leak by kfree(dell_wmi_keymap) if dell_new_hk_type is true.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-07-01 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 9:25 [PATCH] dell-wmi: fix a memory leak Axel Lin
2010-07-01 13:53 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701135348.GF31804@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=axel.lin@gmail.com \
--cc=dtor@mail.ru \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox