From: Matthew Garrett <mjg@redhat.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mattia Dongili <malattia@linux.it>,
Len Brown <len.brown@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stefani Seibold <stefani@seibold.net>,
Andi Kleen <ak@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] sony-laptop: use platform_device_unregister in sony_pf_remove
Date: Thu, 1 Jul 2010 14:54:01 +0100 [thread overview]
Message-ID: <20100701135401.GG31804@srcf.ucam.org> (raw)
In-Reply-To: <1277950681.30073.1.camel@mola>
On Thu, Jul 01, 2010 at 10:18:01AM +0800, Axel Lin wrote:
> platform_device_unregister calls platform_device_del and platform_device_put,
> thus this change is logically equivalent to original code.
>
> I made this change because the documents in platform.c shows that:
> platform_device_del and platform_device_put must _only_ be externally called
> in error cases. All other usage is a bug.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-07-01 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 2:18 [PATCH] sony-laptop: use platform_device_unregister in sony_pf_remove Axel Lin
2010-07-01 13:54 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701135401.GG31804@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox