public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Dan Williams <dan.j.williams@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree-discuss <devicetree-discuss@lists.ozlabs.org>
Subject: Re: [git pull] (updated) OF-related build breakage fixes
Date: Thu, 1 Jul 2010 15:16:24 +0200	[thread overview]
Message-ID: <20100701151624.2bf6c533@wker> (raw)
In-Reply-To: <AANLkTimvYT9MFPzX7xmCXPZ6ScFQZxO3zSKlcqczd_GO@mail.gmail.com>

On Thu, 1 Jul 2010 02:06:35 -0700
Dan Williams <dan.j.williams@gmail.com> wrote:

> of/dma: fix remaining ppc4xx build breakage
> 
> From: Dan Williams <dan.j.williams@intel.com>
> 
> Commit 05c02542 "of/dma: fix build breakage in ppc4xx adma driver"
> missed one conversion site.
> 
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> 
>  drivers/dma/ppc4xx/adma.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Acked-by: Anatolij Gustschin <agust@denx.de>

Thanks for fixing!

> 
> 
> diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> index 5a22ca6..7c37479 100644
> --- a/drivers/dma/ppc4xx/adma.c
> +++ b/drivers/dma/ppc4xx/adma.c
> @@ -4257,10 +4257,12 @@ static int ppc440spe_adma_setup_irqs(struct ppc440spe_adma_device *adev,
>  				     struct ppc440spe_adma_chan *chan,
>  				     int *initcode)
>  {
> +	struct of_device *ofdev;
>  	struct device_node *np;
>  	int ret;
>  
> -	np = container_of(adev->dev, struct of_device, dev)->node;
> +	ofdev = container_of(adev->dev, struct of_device, dev);
> +	np = ofdev->dev.of_node;
>  	if (adev->id != PPC440SPE_XOR_ID) {
>  		adev->err_irq = irq_of_parse_and_map(np, 1);
>  		if (adev->err_irq == NO_IRQ) {

  reply	other threads:[~2010-07-01 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03  3:06 [git pull] (updated) OF-related build breakage fixes Grant Likely
2010-06-03  4:01 ` Wolfram Sang
2010-06-03  4:03 ` [PATCH 1/2] of/powerpc: fix fsl_msi device node pointer Wolfram Sang
2010-06-03  4:50   ` Grant Likely
2010-06-03  4:03 ` [PATCH 2/2] of/crypto: n2_core: fix build breakage Wolfram Sang
2010-06-03  4:25   ` Grant Likely
2010-06-03  9:49   ` David Miller
2010-06-03 10:03     ` Herbert Xu
2010-07-01  9:06 ` [git pull] (updated) OF-related build breakage fixes Dan Williams
2010-07-01 13:16   ` Anatolij Gustschin [this message]
2010-07-02 21:53     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100701151624.2bf6c533@wker \
    --to=agust@denx.de \
    --cc=dan.j.williams@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox