* [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83
@ 2010-07-02 0:04 Dave Airlie
2010-07-02 0:37 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dave Airlie @ 2010-07-02 0:04 UTC (permalink / raw)
To: intel-gfx, linux-kernel; +Cc: Linus Torvalds, Dave Airlie
From: Linus Torvalds <torvalds@linux-foundation.org>
Since 4bdadb9785696439c6e2b3efe34aa76df1149c83, we've been passing
GFP_MOVABLE where we weren't before caused hibernate on Intel hardware
to results in a lot of memory corruptions on resume.
[airlied: linus please enhance commit msg if you commit this]
http://bugzilla.kernel.org/show_bug.cgi?id=13811
Reported-by: Evengi Golov (in bugzilla)
Signed-off-by: Dave Airlie <airlied@redhat.com>
Tested-by: M. Vefa Bicakci <bicave@superonline.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9ded3da..0743858 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2239,7 +2239,7 @@ i915_gem_object_get_pages(struct drm_gem_object *obj,
mapping = inode->i_mapping;
for (i = 0; i < page_count; i++) {
page = read_cache_page_gfp(mapping, i,
- mapping_gfp_mask (mapping) |
+ GFP_HIGHUSER |
__GFP_COLD |
gfpmask);
if (IS_ERR(page))
--
1.7.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83
2010-07-02 0:04 [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83 Dave Airlie
@ 2010-07-02 0:37 ` Greg KH
2010-07-02 1:39 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2010-07-02 0:37 UTC (permalink / raw)
To: Dave Airlie; +Cc: intel-gfx, linux-kernel, Linus Torvalds, Dave Airlie
On Fri, Jul 02, 2010 at 10:04:42AM +1000, Dave Airlie wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
>
> Since 4bdadb9785696439c6e2b3efe34aa76df1149c83, we've been passing
> GFP_MOVABLE where we weren't before caused hibernate on Intel hardware
> to results in a lot of memory corruptions on resume.
>
> [airlied: linus please enhance commit msg if you commit this]
>
> http://bugzilla.kernel.org/show_bug.cgi?id=13811
>
> Reported-by: Evengi Golov (in bugzilla)
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Tested-by: M. Vefa Bicakci <bicave@superonline.com>
This should go into .33 and .34-stable trees, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83
2010-07-02 0:37 ` Greg KH
@ 2010-07-02 1:39 ` Linus Torvalds
0 siblings, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2010-07-02 1:39 UTC (permalink / raw)
To: Greg KH; +Cc: Dave Airlie, intel-gfx, linux-kernel, Dave Airlie
On Thu, Jul 1, 2010 at 5:37 PM, Greg KH <greg@kroah.com> wrote:
>
> This should go into .33 and .34-stable trees, right?
Yup. I added a "cc: stable" to the patch, and it's now commit
985b823b919 in my tree, you'll see it when I push it out along with
the other dri updates.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-02 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-02 0:04 [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83 Dave Airlie
2010-07-02 0:37 ` Greg KH
2010-07-02 1:39 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox