Re: [patch 30/52] fs: icache lock lru/writeback lists

Peter Zijlstra
2010-06-24T15:13:44Z

On Fri, 2010-06-25 at 01:09 +1000, Nick Piggin wrote:
> On Thu, Jun 24, 2010 at 10:58:08AM +0200, Peter Zijlstra wrote:
> > On Thu, 2010-06-24 at 13:02 +1000, npiggin@suse.de wrote:
> > > + assert_spin_locked(&wb_inode_list_lock);
> >
> > There's also lockdep_assert_held() which also validates we're the owner.
>
> These locks should have such miniscule contention now that they
> effectively mean the same thing :) But no that's a good suggestion
> thanks. I guess _most_ assert_spin_locked could be changed over.

Probably, I just haven't felt like actually visiting all sites to
check ;-)