* [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev()
@ 2010-07-03 16:03 Kulikov Vasiliy
2010-07-04 7:51 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-03 16:03 UTC (permalink / raw)
To: Kernel Janitors
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Borislav Petkov, Tejun Heo, linux-kernel
Use for_each_pci_dev() to simplify the code.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/x86/kernel/k8.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c
index 0f7bc20..0ea4b35 100644
--- a/arch/x86/kernel/k8.c
+++ b/arch/x86/kernel/k8.c
@@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges);
static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
{
- do {
- dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
- if (!dev)
+ for_each_pci_dev(dev) {
+ if (pci_match_id(&k8_nb_ids[0], dev))
break;
- } while (!pci_match_id(&k8_nb_ids[0], dev));
+ }
return dev;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev()
2010-07-03 16:03 [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev() Kulikov Vasiliy
@ 2010-07-04 7:51 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2010-07-04 7:51 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86@kernel.org, Tejun Heo, linux-kernel@vger.kernel.org
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Sat, Jul 03, 2010 at 12:03:59PM -0400
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
> arch/x86/kernel/k8.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c
> index 0f7bc20..0ea4b35 100644
> --- a/arch/x86/kernel/k8.c
> +++ b/arch/x86/kernel/k8.c
> @@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges);
>
> static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
> {
> - do {
> - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
> - if (!dev)
> + for_each_pci_dev(dev) {
> + if (pci_match_id(&k8_nb_ids[0], dev))
> break;
> - } while (!pci_match_id(&k8_nb_ids[0], dev));
> + }
> return dev;
> }
>
> --
> 1.7.0.4
>
>
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-04 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 16:03 [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev() Kulikov Vasiliy
2010-07-04 7:51 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox