Re: [RFC][PATCH 05/11] perf: register pmu implementations

Paul Mackerras
2010-07-09T03:09:01Z

On Thu, Jun 24, 2010 at 04:28:09PM +0200, Peter Zijlstra wrote:

> Simple registration interface for struct pmu, this provides the
> infrastructure for removing all the weak functions.

Seems to work on powerpc, but the sh bits don't seem quite right:

> Index: linux-2.6/arch/sh/kernel/perf_event.c
> ===================================================================
> --- linux-2.6.orig/arch/sh/kernel/perf_event.c
> +++ linux-2.6/arch/sh/kernel/perf_event.c
> @@ -257,24 +257,24 @@ static void sh_pmu_read(struct perf_even
> sh_perf_event_update(event, &event->hw, event->hw.idx);
> }
>
> -static struct pmu pmu = {
> - .enable = sh_pmu_enable,
> - .disable = sh_pmu_disable,
> - .read = sh_pmu_read,
> -};
> -
> -struct pmu *hw_perf_event_init(struct perf_event *event)
> +static in sh_pmu_event_init(struct perf_event *event)

int?

> {
> int err = __hw_perf_event_init(event);

We need a switch on event->attr.type so we return -ENOENT if it's
not PERF_TYPE_{HARDWARE,HW_CACHE,RAW}. As it is we don't ever return
-ENOENT, which might stop software and tracepoint events from working.

Paul.