Re: [RFC][PATCH 09/11] perf: Default PMU ops

Frederic Weisbecker
2010-06-29T15:00:06Z

On Tue, Jun 29, 2010 at 04:57:53PM +0200, Peter Zijlstra wrote:
> On Tue, 2010-06-29 at 16:49 +0200, Frederic Weisbecker wrote:
> > > +static void perf_pmu_start_txn(struct pmu *pmu)
> > > +{
> > > + perf_pmu_disable(pmu);
> > > +}
> > > +
> > > +static int perf_pmu_commit_txn(struct pmu *pmu)
> > > +{
> > > + perf_pmu_enable(pmu);
> > > + return 0;
> > > +}
> > > +
> > > +static void perf_pmu_cancel_txn(struct pmu *pmu)
> > > +{
> > > + perf_pmu_enable(pmu);
> >
> >
> > Did you mean disable here?
>
> Nope, start_txn() will disable the pmu, both commit_txn and cancel_txn
> can be used to close the transaction and should thus enable the pmu
> again.

Looks like I read that while walking on my arms, sorry.