From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Martin Filip <bugtraq@smoula.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Macbook Pro 5,5 nvidia backlight fix
Date: Mon, 5 Jul 2010 18:25:52 +0100 [thread overview]
Message-ID: <20100705172552.GA16298@srcf.ucam.org> (raw)
In-Reply-To: <4C31F9C4.8090609@smoula.net>
On Mon, Jul 05, 2010 at 05:27:00PM +0200, Martin Filip wrote:
> Maybe someone involved with this module can merge this one?
This is a really bad idea. You're hardcoding the location of PDISPLAY,
which the kernel is at liberty to remap at boot time, and even then
you're writing into the address space of a device that's controlled by
another driver. Does nouveau not handle this hardware properly?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-07-05 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 15:27 Macbook Pro 5,5 nvidia backlight fix Martin Filip
2010-07-05 17:25 ` Matthew Garrett [this message]
[not found] ` <4C321A0D.20008@smoula.net>
2010-07-05 17:48 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705172552.GA16298@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bugtraq@smoula.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox