From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314Ab0GERZ5 (ORCPT ); Mon, 5 Jul 2010 13:25:57 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:34211 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102Ab0GERZ4 (ORCPT ); Mon, 5 Jul 2010 13:25:56 -0400 Date: Mon, 5 Jul 2010 18:25:52 +0100 From: Matthew Garrett To: Martin Filip Cc: linux-kernel@vger.kernel.org Subject: Re: Macbook Pro 5,5 nvidia backlight fix Message-ID: <20100705172552.GA16298@srcf.ucam.org> References: <4C31F9C4.8090609@smoula.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C31F9C4.8090609@smoula.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 05, 2010 at 05:27:00PM +0200, Martin Filip wrote: > Maybe someone involved with this module can merge this one? This is a really bad idea. You're hardcoding the location of PDISPLAY, which the kernel is at liberty to remap at boot time, and even then you're writing into the address space of a device that's controlled by another driver. Does nouveau not handle this hardware properly? -- Matthew Garrett | mjg59@srcf.ucam.org