Re: [PATCH] Rearrange i_flags to be consistent with FS_IOC_GETFLAGS

David Howells
2010-07-06T13:40:43Z

Dave Chinner <david@fromorbit.com> wrote:

> Further, it opens up the possibility that further down the track
> someone modifies S_* flag values (say when adding some XFS
> functionality) and corrupts extN filesystems all over the place.
> There isn't even compiler guards to catch someone modifying the S_*
> flags in a way that makes it incompatible with the extN on-disk
> definitions.

That occurred to me after I sent the patch. I can add some preprocessor guards
for this.

David