From: Arnd Bergmann <arnd@arndb.de>
To: Ian Kent <raven@themaw.net>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
autofs@linux.kernel.org
Subject: Re: [PATCH 3/6] autofs/autofs4: move compat_ioctl handling into fs
Date: Tue, 6 Jul 2010 13:35:00 +0200 [thread overview]
Message-ID: <201007061335.00264.arnd@arndb.de> (raw)
In-Reply-To: <1278378690.3070.6.camel@localhost>
On Tuesday 06 July 2010, Ian Kent wrote:
> So it makes no difference whether the patches are combined, if it breaks
> autofs then it probably won't be fixed but it may cause the replacement
> to happen sooner.
Well, the main point of applying the patch now is to avoid breaking the
autofs module when we remove the .ioctl operation.
> As far as the patch goes that should be fine and we should be able to
> remove the BKL from autofs4 soon after but I'm not brave enough to try
> just yet.
Well, the only use of the BKL in autofs4 is in the ioctl function. You
can probably replace that trivially with a global mutex, but from a quick
inspection, even that should not be needed: The only ioctl command in
autofs4 that does not already seem to have adequate locking is
autofs4_get_set_timeout, which is even easier to change and still harmless
if you don't do it at all.
Arnd
next prev parent reply other threads:[~2010-07-06 11:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 22:15 [PATCH 0/6] kill .ioctl file_operation Arnd Bergmann
2010-07-03 22:15 ` [PATCH 1/6] ia64/perfmon: convert to unlocked_ioctl Arnd Bergmann
2010-07-21 23:16 ` Frederic Weisbecker
2010-07-03 22:15 ` [PATCH 2/6] sound/oss: " Arnd Bergmann
2010-07-04 11:08 ` Sam Ravnborg
2010-07-04 20:52 ` Arnd Bergmann
2010-07-03 22:15 ` [PATCH 3/6] autofs/autofs4: move compat_ioctl handling into fs Arnd Bergmann
2010-07-05 19:24 ` Frederic Weisbecker
2010-07-05 19:42 ` H. Peter Anvin
2010-07-05 19:48 ` Frederic Weisbecker
2010-07-05 19:52 ` Arnd Bergmann
2010-07-05 19:58 ` Frederic Weisbecker
2010-07-05 20:12 ` H. Peter Anvin
2010-07-06 1:11 ` Ian Kent
2010-07-06 11:35 ` Arnd Bergmann [this message]
2010-07-06 13:17 ` Ian Kent
2010-07-16 0:14 ` Frederic Weisbecker
2010-07-16 4:40 ` Ian Kent
2010-07-16 11:05 ` Arnd Bergmann
2010-07-16 12:09 ` Frederic Weisbecker
2010-07-03 22:15 ` [PATCH 4/6] cris: Pushdown the bkl from ioctl Arnd Bergmann
2010-07-30 17:08 ` Jesper Nilsson
2010-07-03 22:15 ` [PATCH 5/6] v4l: convert v4l2-dev to unlocked_ioctl Arnd Bergmann
2010-07-05 19:27 ` Frederic Weisbecker
2010-07-03 22:15 ` [PATCH 6/6] bkl: remove locked .ioctl file operation Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007061335.00264.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=autofs@linux.kernel.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox