From: Alan Cox <alan@linux.intel.com>
To: kagen101@gmail.com
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c
Date: Tue, 6 Jul 2010 22:29:54 +0100 [thread overview]
Message-ID: <20100706222954.432ffcdd@linux.intel.com> (raw)
In-Reply-To: <1278436628.5396.75.camel@dermezel>
On Tue, 06 Jul 2010 19:17:08 +0200
Joe Eloff <kagen101@gmail.com> wrote:
> >From e23e19537c4d62bc76ae982859d3c3225a45d9c2 Mon Sep 17 00:00:00
> >2001
> From: Joe Eloff <kagen101@gmail.com>
> Date: Tue, 6 Jul 2010 19:13:28 +0200
> Subject: [PATCH] Staging: et131x: fix coding style issues in
> et131x_initpci.c
>
> This is a patch to the et131x_initpci.c file that fixes up all the
> line lengths over 80 by the checkpatch.pl tool.
That is one area where checkpatch can be misleading. If you split
messages like that it becomes hard to grep for them.
Where it is useful is where you have
printk("blah blah bah blah [120 chars]", functioncall(foo))
and it would hide things like functioncall(foo)
No argument about the comment ones however.
next prev parent reply other threads:[~2010-07-06 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 17:17 [PATCH] Staging: et131x: fix coding style issues in et131x_initpci.c Joe Eloff
2010-07-06 19:25 ` Nick Bowler
2010-07-06 21:29 ` Alan Cox [this message]
2010-07-07 5:43 ` Joe Eloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706222954.432ffcdd@linux.intel.com \
--to=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kagen101@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox