* [PATCH] staging/panel: Prevent double-calling of parport_release - fix oops.
@ 2010-07-07 2:52 Peter Huewe
2010-07-07 4:13 ` Willy Tarreau
0 siblings, 1 reply; 2+ messages in thread
From: Peter Huewe @ 2010-07-07 2:52 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Willy Tarreau, Julia Lawall, Sudhakar Rajashekhara, devel,
linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
This patch prevents the code from calling parport_release and
parport_unregister_device twice with the same arguments - and thus fixes an oops.
Rationale:
After the first call the parport is already released and the
handle isn't valid anymore and calling parport_release and
parport_unregister_device twice isn't a good idea.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
KernelVersion: linux-next-20100607
drivers/staging/panel/panel.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3154ffe..6fa57be 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2277,6 +2277,7 @@ int panel_init(void)
if (pprt) {
parport_release(pprt);
parport_unregister_device(pprt);
+ pprt = NULL;
}
parport_unregister_driver(&panel_driver);
printk(KERN_ERR "Panel driver version " PANEL_VERSION
@@ -2327,6 +2328,7 @@ static void __exit panel_cleanup_module(void)
/* TODO: free all input signals */
parport_release(pprt);
parport_unregister_device(pprt);
+ pprt = NULL;
}
parport_unregister_driver(&panel_driver);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging/panel: Prevent double-calling of parport_release - fix oops.
2010-07-07 2:52 [PATCH] staging/panel: Prevent double-calling of parport_release - fix oops Peter Huewe
@ 2010-07-07 4:13 ` Willy Tarreau
0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2010-07-07 4:13 UTC (permalink / raw)
To: Peter Huewe
Cc: Greg Kroah-Hartman, Julia Lawall, Sudhakar Rajashekhara, devel,
linux-kernel
On Wed, Jul 07, 2010 at 04:52:16AM +0200, Peter Huewe wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch prevents the code from calling parport_release and
> parport_unregister_device twice with the same arguments - and thus fixes an oops.
>
> Rationale:
> After the first call the parport is already released and the
> handle isn't valid anymore and calling parport_release and
> parport_unregister_device twice isn't a good idea.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> KernelVersion: linux-next-20100607
>
> drivers/staging/panel/panel.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 3154ffe..6fa57be 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -2277,6 +2277,7 @@ int panel_init(void)
> if (pprt) {
> parport_release(pprt);
> parport_unregister_device(pprt);
> + pprt = NULL;
> }
> parport_unregister_driver(&panel_driver);
> printk(KERN_ERR "Panel driver version " PANEL_VERSION
> @@ -2327,6 +2328,7 @@ static void __exit panel_cleanup_module(void)
> /* TODO: free all input signals */
> parport_release(pprt);
> parport_unregister_device(pprt);
> + pprt = NULL;
> }
> parport_unregister_driver(&panel_driver);
> }
> --
> 1.7.1
look fine, ACK by me !
Willy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-07 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-07 2:52 [PATCH] staging/panel: Prevent double-calling of parport_release - fix oops Peter Huewe
2010-07-07 4:13 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox