From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
xiaosuo@gmail.com, tim.gardner@canonical.com,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 0/3] splice fixes
Date: Wed, 7 Jul 2010 13:38:51 -0700 [thread overview]
Message-ID: <20100707133851.7c805c2d.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C29E1A0.7070601@kernel.dk>
On Tue, 29 Jun 2010 14:05:52 +0200
Jens Axboe <axboe@kernel.dk> wrote:
> On 2010-06-29 14:05, Miklos Szeredi wrote:
> > On Tue, 29 Jun 2010, Jens Axboe wrote:
> >> On 2010-06-29 13:08, Miklos Szeredi wrote:
> >>> These patches fix bugs that affect real-world users of splice(2) and
> >>> sendfile(2) interfaces.
> >>>
> >>> Not sure if some or all of them are appropriate for 2.6.35 and/or
> >>> -stable?
> >>
> >> I think that 1-2 should go into 2.6.35 directly, and 3 for .36 with
> >> a stable backport as well. Agree?
> >
> > Yes, sounds good.
>
> Good, that is what I queued up. I haven't pushed out the updated
> for-linus yet, since I asked Linus to pull it this morning.
>
According to Tim's report on lkml
(http://lkml.org/lkml/2010/6/25/280),
cc56f7de7f00d188c7c4da1e9861581853b9e92f caused a regression.
cc56f7de7f00d188c7c4da1e9861581853b9e92f is present in 2.6.33 and in
2.6.34 hence the fix should be backported into -stable.
According to http://bugs.launchpad.net/bugs/588861, the patch "splice:
direct_splice_actor() should not use pos in sd" fixes the regression.
However this:
commit 4f9078afb4e083e033aafbbfabe729cb3832aa42
Author: Changli Gao <xiaosuo@gmail.com>
Date: Tue Jun 29 13:09:18 2010 +0200
splice: direct_splice_actor() should not use pos in sd
went into mainline without a cc:stable tag.
next prev parent reply other threads:[~2010-07-07 20:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 11:08 [PATCH 0/3] splice fixes Miklos Szeredi
2010-06-29 11:09 ` [PATCH 1/3] splice: direct_splice_actor() should not use pos in sd Miklos Szeredi
2010-06-29 11:10 ` [PATCH 2/3] splice: check f_mode for seekable file Miklos Szeredi
2010-06-29 11:13 ` [PATCH 3/3] splice: fix misuse of SPLICE_F_NONBLOCK Miklos Szeredi
2010-06-29 11:15 ` [PATCH 0/3] splice fixes Jens Axboe
2010-06-29 12:05 ` Miklos Szeredi
2010-06-29 12:05 ` Jens Axboe
2010-07-07 20:38 ` Andrew Morton [this message]
2010-07-08 13:36 ` Jens Axboe
2010-07-08 13:38 ` Jens Axboe
2010-07-08 17:25 ` Andrew Morton
2010-07-08 17:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707133851.7c805c2d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stable@kernel.org \
--cc=tim.gardner@canonical.com \
--cc=torvalds@linux-foundation.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox