From: Christoph Hellwig <hch@infradead.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: hch@infradead.org, axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] remove q->prepare_flush_fn hook
Date: Wed, 7 Jul 2010 19:58:29 -0400 [thread overview]
Message-ID: <20100707235829.GA6390@infradead.org> (raw)
In-Reply-To: <20100708085404K.fujita.tomonori@lab.ntt.co.jp>
On Thu, Jul 08, 2010 at 08:54:59AM +0900, FUJITA Tomonori wrote:
> On Wed, 7 Jul 2010 15:52:09 -0400
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > One weird thing after this set is that the flush commands don't have any
> > cmd_type. I think it should be set to REQ_TYPE_FS, even if we might be
> > resetting it inside the driver for now.
>
> I think even before this patchset, the block layer doesn't set
> rq->cmd_type on flush requests (scsi and Ode sets it in
> prepare_flush_fn).
Indeed it didn't. But before that it matters less because
prepare_flush_fn set it before the command entered prep_fn.
prev parent reply other threads:[~2010-07-07 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 8:45 [PATCH 0/9] remove q->prepare_flush_fn hook FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 1/9] block: introduce REQ_FLUSH flag FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 2/9] block: permit PREFLUSH and POSTFLUSH without prepare_flush_fn FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 3/9] scsi: stop using q->prepare_flush_fn FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 4/9] osdblk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 5/9] ps3disk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 6/9] dm: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 7/9] virtio_blk: " FUJITA Tomonori
2010-07-03 8:45 ` [PATCH 8/9] ide: " FUJITA Tomonori
2010-07-03 16:48 ` David Miller
2010-07-03 8:45 ` [PATCH 9/9] block: remove q->prepare_flush_fn completely FUJITA Tomonori
2010-07-03 10:13 ` Christoph Hellwig
2010-07-03 10:02 ` [PATCH 0/9] remove q->prepare_flush_fn hook Christoph Hellwig
2010-07-05 6:55 ` Jens Axboe
2010-07-05 8:01 ` FUJITA Tomonori
2010-07-05 8:03 ` Jens Axboe
2010-07-07 19:52 ` Christoph Hellwig
2010-07-07 23:54 ` FUJITA Tomonori
2010-07-07 23:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707235829.GA6390@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox