The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: "Ma, Ling" <ling.ma@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH -tip] Revert x86, mem: Optimize memcpy by avoiding memory false dependece
Date: Thu, 8 Jul 2010 09:11:53 +0200	[thread overview]
Message-ID: <20100708071153.GH4414@elte.hu> (raw)
In-Reply-To: <20100708062733.GA24740@Krystal>


* Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> * Ma, Ling (ling.ma@intel.com) wrote:
> > Hi Mathieu
> > 
> > I did git revert as bellow
> >     Revert "x86, mem: Optimize memcpy by avoiding memory false dependece"
> > 
> >     This reverts commit 77ff5e49c20bb72a99a12bfb00dbf90b2302f087.
> > And I found the machine will crash with your config file
> > 
> > Could you revert the patch : 77ff5e49c20bb72a99a12bfb00dbf90b2302f087 on your
> > machine, and check it again ?
> 
> Hi Ling,
> 
> I just successfully booted my machine 3 times in a row with a revert of 
> commit a1e5278e40f16a4611264f8da9e557c16cb6f6ed from -tip. This is actually 
> the same as reverting commit 77ff5e49c20bb72a99a12bfb00dbf90b2302f087, as 
> a1e5278e40f16a4611264f8da9e557c16cb6f6ed is simply a merge of that commit 
> (the diffs are exactly the same).
> 
> Without this revert, the machine gets to:

Please check latest -tip (2a74852 or later), the commit should be gone now.

There's clearly some (boundary-condition?) bug in the assembly code of 
77ff5e49c2.

Thanks,

	Ingo

  reply	other threads:[~2010-07-08  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  6:27 [PATCH -tip] Revert x86, mem: Optimize memcpy by avoiding memory false dependece Mathieu Desnoyers
2010-07-08  7:11 ` Ingo Molnar [this message]
2010-07-08 15:00   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708071153.GH4414@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=ling.ma@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox