Re: [PATCH 4/4] Staging: vme: devices: fix coding style issues in vme_user.c

[Greg KH <greg@kroah.com>]

On Mon, Jul 05, 2010 at 10:18:10AM +0100, Martyn Welch wrote:
> Martyn Welch wrote:
> > Gustavo Silva wrote:
> >   
> >> This is a patch to the vme_user.c file that fixes up the following
> >> issues:
> >>
> >> WARNING: please, no space before tabs						x 12
> >> ERROR: code indent should use tabs where possible				x 15
> >> WARNING: braces {} are not necessary for single statement blocks		x  2
> >> WARNING: printk() should include KERN_ facility level				x  3
> >> ERROR: "foo * bar" should be "foo *bar"						x  1
> >> ERROR: space required before the open brace '{'					x  3
> >> WARNING: space prohibited between function name and open parenthesis '('	x  1
> >> ERROR: spaces required around that '=' (ctx:VxV)				x  2
> >> ERROR: spaces required around that '<' (ctx:VxV)				x  2
> >> ERROR: space required after that ',' (ctx:VxV)					x  3
> >> ERROR: spaces required around that '?' (ctx:VxW)				x  1
> >> ERROR: space required before the open parenthesis '('				x  1
> >> WARNING: braces {} are not necessary for single statement blocks		x  2
> >>
> >>   
> >>     
> >
> > This looks very familiar - I'm sure there was a patch already on the
> > mailing list doing this, but it has some issues which I don't think were
> > ever addressed. This one looks good though.
> >
> >   
> Hmm, seems the earlier patch was fixed up and is now in linux-next, sorry.

Yeah, this doesn't apply :(

thanks,

greg k-h