From: Andrew Morton <akpm@linux-foundation.org>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org, hare@suse.de,
stable@kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Jason Baron <jbaron@redhat.com>
Subject: Re: Dynamic Debug lib: Fix memory corruption for specific module declarations
Date: Fri, 9 Jul 2010 16:57:52 -0700 [thread overview]
Message-ID: <20100709165752.0daac206.akpm@linux-foundation.org> (raw)
In-Reply-To: <201007091310.43314.trenn@suse.de>
On Fri, 9 Jul 2010 13:10:42 +0200
Thomas Renninger <trenn@suse.de> wrote:
> From: Jason Baron <jbaron@redhat.com>
You forgot to cc Jason.
> Make sure we properly call ddebug_remove_module() when a module fails to
> load. In addition, pass the pointer to the "debug table", to both
> ddebug_add_module(), and ddebug_remove_module() so that we can uniquely
> identify each set of debug statements. In this way even modules with the
> same name can be properly identified and removed.
>
> Kernel bug reference:
> http://bugzilla.kernel.org/show_bug.cgi?id=16330
>
> By trenn (for stable people):
> Not sure for how long this bug exists (always?), it nearly patches
> fine for a 2.6.32 kernel...
It's unclear what kernel this is against. It applies quite badly to
mainline. I fixed all that up then lost the result :( It doesn't apply
cleanly to 2.6.34 either.
I was going to steal your changelog and add it to Jason's patch but
Jason's patch generates a reject storm against mainline too.
Giving up.
prev parent reply other threads:[~2010-07-09 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 11:10 Dynamic Debug lib: Fix memory corruption for specific module declarations Thomas Renninger
2010-07-09 23:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709165752.0daac206.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hare@suse.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox