From: Greg KH <greg@kroah.com>
To: Thomas Renninger <trenn@suse.de>
Cc: lenb@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
astarikovskiy@suse.de, Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH 1/6] ACPI: Provide /sys/devices/system/ec/
Date: Fri, 9 Jul 2010 12:18:58 -0700 [thread overview]
Message-ID: <20100709191858.GC8989@kroah.com> (raw)
In-Reply-To: <1277996570-2686-2-git-send-email-trenn@suse.de>
On Thu, Jul 01, 2010 at 05:02:45PM +0200, Thomas Renninger wrote:
> +config ACPI_EC_SYSFS
> + tristate "EC read/write access through sysfs"
> + default y
> + help
> + Say N to disable Embedded Controller /sys interface
> +
> + An Embedded Controller typically is available on laptops and reads
> + sensor values like battery state and temperature.
> + The kernel access the EC through ACPI parsed code provided by BIOS
> + tables.
> + Thus this option is a debug option that helps to write ACPI drivers
> + and which can be used to identify ACPI code or EC firmware bugs.
Wait, why is this a sysfs file at all? It should be a debugfs one,
right?
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-09 19:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 15:02 Provide /sys/../ec with read/write access and some cleanups Thomas Renninger
2010-07-01 15:02 ` [PATCH 1/6] ACPI: Provide /sys/devices/system/ec/ Thomas Renninger
2010-07-09 19:18 ` Greg KH
2010-07-09 19:18 ` Greg KH [this message]
2010-07-01 15:02 ` [PATCH 2/6] ACPI: Provide /sys/devices/system/ec/*/io for binary access to the EC Thomas Renninger
2010-07-01 15:02 ` [PATCH 3/6] ACPI: Register EC io ports in /proc/ioports Thomas Renninger
2010-07-01 15:02 ` [PATCH 4/6] ACPI: Remove /proc/acpi/embedded_controller/ Thomas Renninger
2010-07-01 15:02 ` [PATCH 5/6] X86 platform drivers: Remove EC dump from thinkpad_acpi Thomas Renninger
2010-07-01 16:27 ` Henrique de Moraes Holschuh
2010-07-01 19:31 ` Thomas Renninger
2010-07-01 23:26 ` Henrique de Moraes Holschuh
2010-07-02 9:14 ` Thomas Renninger
2010-07-02 15:58 ` Henrique de Moraes Holschuh
2010-07-01 15:02 ` [PATCH 6/6] X86 platform driver: Fix section mismatch in wmi.c Thomas Renninger
2010-07-01 16:22 ` Provide /sys/../ec with read/write access and some cleanups Henrique de Moraes Holschuh
2010-07-01 19:44 ` Thomas Renninger
2010-07-01 23:27 ` Henrique de Moraes Holschuh
2010-07-01 20:47 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709191858.GC8989@kroah.com \
--to=greg@kroah.com \
--cc=astarikovskiy@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox