From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v2] x86: Early-boot serial I/O support
Date: Sun, 11 Jul 2010 01:32:11 +0400 [thread overview]
Message-ID: <20100710213211.GD6615@lenovo> (raw)
In-Reply-To: <AANLkTim1wgrOaz5rXV-Cea3IjcZejrsRrCO0AUkcrOv-@mail.gmail.com>
On Sun, Jul 11, 2010 at 12:18:06AM +0300, Pekka Enberg wrote:
> On Sun, Jul 11, 2010 at 12:07 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >> @@ -203,6 +205,17 @@ static inline int isdigit(int ch)
> >> return (ch >= '0') && (ch <= '9');
> >> }
> >>
> >> +static inline int isxdigit(int ch)
> >> +{
> >> + if (isdigit(ch))
> >> + return true;
> >> +
> >> + if ((ch >= 'a') && (ch <= 'f'))
> >> + return true;
> >> +
> >> + return (ch >= 'A') && (ch <= 'F');
> >> +}
> >> +
> >
> > I suspect it's supposed to be static inline *bool*, right?
>
> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'.
>
> Pekka
>
ok, I see
-- Cyrill
next prev parent reply other threads:[~2010-07-10 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 19:40 [PATCH v2] x86: Early-boot serial I/O support Pekka Enberg
2010-07-10 20:49 ` Yinghai Lu
2010-07-10 21:17 ` Pekka Enberg
2010-07-10 21:27 ` H. Peter Anvin
2010-07-10 21:32 ` Pekka Enberg
2010-07-10 21:07 ` Cyrill Gorcunov
2010-07-10 21:18 ` Pekka Enberg
2010-07-10 21:32 ` Cyrill Gorcunov [this message]
2010-07-10 21:36 ` H. Peter Anvin
2010-07-10 21:37 ` H. Peter Anvin
2010-07-10 21:55 ` Cyrill Gorcunov
2010-07-10 22:30 ` H. Peter Anvin
2010-07-11 7:10 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100710213211.GD6615@lenovo \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox