Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors

Jean Delvare
2010-07-11T17:00:39Z

On Sun, 11 Jul 2010 09:16:58 -0700, Guenter Roeck wrote:
> On Sun, Jul 11, 2010 at 11:31:06AM -0400, Joe Perches wrote:
> > On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote:
> > > + for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {
> > > + if (manid == jc42_chips[i].manid
> > > + && (devid & jc42_chips[i].devid_mask) ==
> > > + jc42_chips[i].devid) {
> > > + strlcpy(info->type, "jc42", I2C_NAME_SIZE);
> > > + return 0;
> > > + }
> > > + }
> >
> > Decidedly trivial:
> >
> > Kernel style seems to prefer having logical tests at
> > end of line rather than start of line.
>
> Ok. Would be nice to have checkpatch.pl complain about it, though,
> if it is a to-be-enforced rule.

Please, not again. This has been discussed before, with the conclusion
that nobody really cares and we don't want to add pointless warnings to
checkpatch.pl, which in the end will just dissuade people from running
the script and/or contributing to the kernel at all.

--
Jean Delvare