Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors

Joe Perches
2010-07-11T15:31:12Z

On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote:
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> new file mode 100644
> index 0000000..685057d
> --- /dev/null
> +++ b/drivers/hwmon/jc42.c
[]
> +struct jc42_chips {
> + u16 manid;
> + u16 devid;
> + u16 devid_mask;
> +};
> +
> +static struct jc42_chips jc42_chips[] = {
> + { ADT_MANID, ADT7408_DEVID, ADT7408_DEVID_MASK },
> + { IDT_MANID, TS3000B3_DEVID, TS3000B3_DEVID_MASK },
> + { MAX_MANID, MAX6604_DEVID, MAX6604_DEVID_MASK },
> + { MCP_MANID, MCP98242_DEVID, MCP98242_DEVID_MASK },
> + { MCP_MANID, MCP98243_DEVID, MCP98243_DEVID_MASK },
> + { MCP_MANID, MCP9843_DEVID, MCP9843_DEVID_MASK },
> + { NXP_MANID, SE97_DEVID, SE97_DEVID_MASK },
> + { ONS_MANID, CAT6095_DEVID, CAT6095_DEVID_MASK },
> + { NXP_MANID, SE98_DEVID, SE98_DEVID_MASK },
> + { STM_MANID, STTS424_DEVID, STTS424_DEVID_MASK },
> + { STM_MANID, STTS424E_DEVID, STTS424E_DEVID_MASK },
> +};
[]
> + for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {
> + if (manid == jc42_chips[i].manid
> + && (devid & jc42_chips[i].devid_mask) ==
> + jc42_chips[i].devid) {
> + strlcpy(info->type, "jc42", I2C_NAME_SIZE);
> + return 0;
> + }
> + }

Decidedly trivial:

Kernel style seems to prefer having logical tests at
end of line rather than start of line.

Maybe this bit would be more readable with a temporary:

for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {
struct jc42_chips *chip = &jc42_chips[i];
if (manid == chip->manid &&
(devid & chip->devid_mask) == chip->devid) {
strlcpy(info->type, "jc42", I2C_NAME_SIZE);
return 0;
}
}