public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Oleg Nesterov <oleg@redhat.com>, Mark Wielaard <mjw@redhat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Naren A Devaiah <naren.devaiah@in.ibm.com>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCHv9 2.6.35-rc4-tip 13/13]  [RFC] perf: show functions in a file without using pid
Date: Mon, 12 Jul 2010 16:04:42 +0530	[thread overview]
Message-ID: <20100712103442.27491.88806.sendpatchset@localhost6.localdomain6> (raw)
In-Reply-To: <20100712103214.27491.15142.sendpatchset@localhost6.localdomain6>


[RFC] perf: show functions in a file without using pid

Lists function names in a dso. Dso needs to a filename.
However passing Dso short name will not work.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---

Show last 10 functions in /bin/zsh.

# perf probe -S -D /bin/zsh | tail
zstrtol
ztrcmp
ztrdup
ztrduppfx
ztrftime
ztrlen
ztrncpy
ztrsub
zwarn
zwarnnam

 tools/perf/util/probe-event.c |   56 ++++++++++++++++++++++++-----------------
 tools/perf/util/symbol.c      |    9 +++++++
 tools/perf/util/symbol.h      |    1 +
 3 files changed, 43 insertions(+), 23 deletions(-)


diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 05b0748..df7cbe8 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1922,13 +1922,13 @@ static int print_list_available_symbols(struct map *map,
 int show_possible_probes(struct strlist *limitlist, pid_t pid)
 {
 	struct perf_session *session;
-	struct thread *thread;
+	struct thread *thread = NULL;
 	struct str_node *ent;
 	struct map *map = NULL;
 	char *name, *str;
 	int ret = -EINVAL;
 
-	if (!pid) {
+	if (!pid && !limitlist) { /* Show functions in kernel */
 		ret = init_vmlinux();
 		if (ret < 0)
 			return ret;
@@ -1947,16 +1947,20 @@ int show_possible_probes(struct strlist *limitlist, pid_t pid)
 	if (symbol__init() < 0)
 		semantic_error("Cannot initialize symbols.");
 
-	event__synthesize_thread(pid, event__process, session);
+	if (pid)  {
+		event__synthesize_thread(pid, event__process, session);
 
-	thread = perf_session__findnew(session, pid);
-	if (!thread)
-		goto out_delete;
+		thread = perf_session__findnew(session, pid);
+		if (!thread)
+			goto out_delete;
+		if (!limitlist) {
+			ret = map_groups__iterate_maps(&thread->mg,
+					MAP__FUNCTION, NULL,
+					print_list_available_symbols);
+			goto out_delete;
+		}
+	}
 
-	if (!limitlist)
-		ret = map_groups__iterate_maps(&thread->mg,
-				MAP__FUNCTION, NULL,
-				print_list_available_symbols);
 	strlist__for_each(ent, limitlist) {
 		str = strdup(ent->s);
 		if (!str) {
@@ -1964,19 +1968,25 @@ int show_possible_probes(struct strlist *limitlist, pid_t pid)
 			goto out_delete;
 		}
 
-		name = basename(make_absolute_path(str));
-		if (!name) {
-			pr_warning("Skip probe listing in %s DSO.", str);
-			free(str);
-			continue;
-		}
-		map = map_groups__find_by_name(&thread->mg,
-						MAP__FUNCTION, name);
-		if (!map) {
-			pr_warning("Skip probe listing in %s DSO.", str);
-			free(str);
-			continue;
-		}
+		if (pid) {
+			name = basename(make_absolute_path(str));
+			if (!name) {
+				pr_warning("Skip probe listing in %s DSO.",
+							str);
+				free(str);
+				continue;
+			}
+			map = map_groups__find_by_name(&thread->mg,
+							MAP__FUNCTION, name);
+			if (!map) {
+				pr_warning("Skip probe listing in %s DSO.",
+							str);
+				free(str);
+				continue;
+			}
+		} else
+			map = dso__new_map(str);
+
 		ret = print_list_available_symbols(map, NULL);
 		if (ret)
 			pr_warning("Unknown dso %s .\n", str);
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 18bb1d8..d2e9123 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -2381,3 +2381,12 @@ void dso__list_available_symbols(struct dso *self, enum map_type type)
 		printf("%s\n", pos->sym.name);
 	}
 }
+
+
+struct map *dso__new_map(char *name)
+{
+	struct dso *dso = dso__new(name);
+	struct map *map = map__new2(0, dso, MAP__FUNCTION);
+
+	return map;
+}
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index 04614b0..34e046c 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -196,6 +196,7 @@ void dso__set_long_name(struct dso *self, char *name);
 void dso__set_build_id(struct dso *self, void *build_id);
 void dso__read_running_kernel_build_id(struct dso *self, struct machine *machine);
 void dso__list_available_symbols(struct dso *self, enum map_type type);
+struct map *dso__new_map(char *name);
 struct symbol *dso__find_symbol(struct dso *self, enum map_type type, u64 addr);
 struct symbol *dso__find_symbol_by_name(struct dso *self, enum map_type type,
 					const char *name);

  parent reply	other threads:[~2010-07-12 10:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 10:32 [PATCHv9 2.6.35-rc4-tip 0/13] Uprobes Patches: Srikar Dronamraju
2010-07-12 10:32 ` [PATCHv9 2.6.35-rc4-tip 1/13] mm: Move replace_page() / write_protect_page() to mm/memory.c Srikar Dronamraju
2010-07-12 10:32 ` [PATCHv9 2.6.35-rc4-tip 2/13] uprobes: Breakpoint insertion/removal in user space applications Srikar Dronamraju
2010-07-20  4:28   ` Christoph Hellwig
2010-07-20  7:22     ` Srikar Dronamraju
2010-08-04 12:05       ` Peter Zijlstra
2010-08-04 12:48         ` Srikar Dronamraju
2010-08-04 13:02           ` Peter Zijlstra
2010-07-12 10:32 ` [PATCHv9 2.6.35-rc4-tip 3/13] uprobes: Slot allocation for Execution out of line(XOL) Srikar Dronamraju
2010-07-12 10:32 ` [PATCHv9 2.6.35-rc4-tip 4/13] uprobes: x86 specific functions for user space breakpointing Srikar Dronamraju
2010-07-12 10:33 ` [PATCHv9 2.6.35-rc4-tip 5/13] uprobes: Uprobes (un)registration and exception handling Srikar Dronamraju
2010-07-12 10:33 ` [PATCHv9 2.6.35-rc4-tip 6/13] uprobes: X86 support for Uprobes Srikar Dronamraju
2010-07-12 10:33 ` [PATCHv9 2.6.35-rc4-tip 7/13] uprobes: Uprobes Documentation Srikar Dronamraju
2010-07-12 10:33 ` [PATCHv9 2.6.35-rc4-tip 8/13] trace: Extract out common code for kprobes/uprobes traceevents Srikar Dronamraju
2010-07-12 10:34 ` [PATCHv9 2.6.35-rc4-tip 9/13] trace: uprobes trace_event interface Srikar Dronamraju
2010-07-12 10:34 ` [PATCHv9 2.6.35-rc4-tip 10/13] perf: Re-Add make_absolute_path Srikar Dronamraju
2010-07-12 14:00   ` Arnaldo Carvalho de Melo
2010-07-12 14:30     ` Steven Rostedt
2010-07-12 16:12       ` Arnaldo Carvalho de Melo
2010-07-14  2:49         ` Steven Rostedt
2010-07-14 16:23           ` Arnaldo Carvalho de Melo
2010-07-14 20:45             ` Ingo Molnar
2010-07-14 20:50               ` Mathieu Desnoyers
2010-07-12 15:33     ` Srikar Dronamraju
2010-07-12 16:26       ` Arnaldo Carvalho de Melo
2010-07-12 17:26         ` Srikar Dronamraju
2010-07-12 10:34 ` [PATCHv9 2.6.35-rc4-tip 11/13] perf: perf interface for uprobes Srikar Dronamraju
2010-07-12 16:03   ` Arnaldo Carvalho de Melo
2010-07-12 17:32     ` Srikar Dronamraju
2010-07-12 10:34 ` [PATCHv9 2.6.35-rc4-tip 12/13] [RFC] perf: Show Potential probe points Srikar Dronamraju
2010-07-12 14:41   ` Arnaldo Carvalho de Melo
2010-07-12 15:55     ` Srikar Dronamraju
2010-07-12 10:34 ` Srikar Dronamraju [this message]
2010-07-20  4:19 ` [PATCHv9 2.6.35-rc4-tip 0/13] Uprobes Patches: Christoph Hellwig
2010-07-20  6:38   ` Srikar Dronamraju
2010-07-20 21:03     ` Arnaldo Carvalho de Melo
2010-07-21  2:42       ` Srikar Dronamraju
2010-07-21 13:08         ` Steven Rostedt
2010-07-21 13:21           ` Srikar Dronamraju
2010-07-21 13:26             ` Christoph Hellwig
2010-07-21 14:10               ` Steven Rostedt
2010-07-21 14:22         ` Arnaldo Carvalho de Melo
2010-07-21 15:50           ` Steven Rostedt
2010-07-21 13:19       ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100712103442.27491.88806.sendpatchset@localhost6.localdomain6 \
    --to=srikar@linux.vnet.ibm.com \
    --cc=acme@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=mjw@redhat.com \
    --cc=naren.devaiah@in.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@xenotime.net \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox