From: Andi Kleen <andi@firstfloor.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Thomas Renninger <trenn@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
yehuda@hq.newdream.net
Subject: Re: Dynamic Debug broken on 2.6.35-rc3?
Date: Mon, 12 Jul 2010 23:47:54 +0200 [thread overview]
Message-ID: <20100712214754.GC17978@basil.fritz.box> (raw)
In-Reply-To: <20100712162140.GA2925@redhat.com>
On Mon, Jul 12, 2010 at 12:21:40PM -0400, Jason Baron wrote:
> On Mon, Jul 12, 2010 at 04:24:16PM +0200, Thomas Renninger wrote:
> > Hi,
> >
> > it's this one:
> > commit ff49d74ad383f54041378144ca1a229ee9aeaa59
> > Author: Yehuda Sadeh <yehuda@hq.newdream.net>
> > Date: Sat Jul 3 13:07:35 2010 +1000
> >
> > which touches same code than Jason's fix does.
> > Possibly this patch also addresses (only parts of?) this problem?
> > Jason: Do you mind having a look at the latest git version and review
> > Yehuda's and adjust your patch if still necessary.
>
> So Yehuda's patch is meant to address this issue. I would still move the
> remove code to free_module(), for the case that load_module() fails as
> follows (on top of Yehuda's patch):
One of the known failures with this was a module that was just missing its exit
function, but otherwise working. Is the patch likely to address this
too?
-Andi
next prev parent reply other threads:[~2010-07-12 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 15:44 Dynamic Debug broken on 2.6.35-rc3? Thomas Renninger
2010-07-01 16:26 ` Jason Baron
2010-07-02 16:55 ` Thomas Renninger
2010-07-08 21:39 ` Jason Baron
2010-07-08 21:53 ` Andrew Morton
2010-07-09 11:03 ` Thomas Renninger
2010-07-09 13:30 ` Jason Baron
2010-07-12 14:24 ` Thomas Renninger
2010-07-12 16:21 ` Jason Baron
2010-07-12 21:21 ` Yehuda Sadeh
2010-07-12 21:47 ` Andi Kleen [this message]
2010-07-13 20:38 ` Yehuda Sadeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712214754.GC17978@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox