public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Dajun Chen <dajun.chen@gmail.com>
Cc: dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/11] Power:Battery module of DA9052 PMIC device driver
Date: Wed, 14 Jul 2010 13:24:51 +0400	[thread overview]
Message-ID: <20100714092451.GA2242@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTikjGNceWZr3IsO8cqKlulDTrEuAQTWH6lB_kSmJ@mail.gmail.com>

On Wed, Jul 14, 2010 at 10:04:11AM +0100, Dajun Chen wrote:
> Battery module of the device driver for DA9052 PMIC device from Dialog
> Semiconductor.
> 
> Changes made since last submission:
> . code has been reorganised as per the standard linux kernel driver
> framework
> . removal of redundant printk and comments
> . removal of test framework
> 
> Linux Kernel Version: 2.6.34
> 
> Signed-off-by: D. Chen <dchen@diasemi.com>
> ---
> diff -urpN linux-2.6.34/drivers/power/da9052_battery.c
> linux-2.6.34_test/drivers/power/da9052_battery.c
> --- linux-2.6.34/drivers/power/da9052_battery.c 1970-01-01
> 05:00:00.000000000 +0500
> +++ linux-2.6.34_test/drivers/power/da9052_battery.c 2010-07-13
> 17:49:01.000000000 +0500
> @@ -0,0 +1,1377 @@

The patch is line wrapped.

> +static int da9052_read(struct da9052 *da9052, u8 reg_address, u8 *reg_data)
> +{
> + struct da9052_ssc_msg msg;
> + int ret;
> +

And whitespace broken.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

           reply	other threads:[~2010-07-14  9:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <AANLkTikjGNceWZr3IsO8cqKlulDTrEuAQTWH6lB_kSmJ@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100714092451.GA2242@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=dajun.chen@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox