Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

Stephen Hemminger
2010-05-05T17:53:11Z

On Wed, 5 May 2010 13:39:51 -0400
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, May 05, 2010 at 10:35:28AM -0700, Dmitry Torokhov wrote:
> > Yes, with the exception that the only body of code that will be
> > accepted by the shell should be GPL-licensed and thus open and available
> > for examining. This is not different from having a standard kernel
> > module that is loaded normally and plugs into a certain subsystem.
> > The difference is that the binary resides not on guest filesystem
> > but elsewhere.
>
> Forget about the licensing. Loading binary blobs written to a shim
> layer is a complete pain in the ass and totally unsupportable, and
> also uninteresting because of the overhead.
>
> If you have any interesting in developing this further, do:
>
> (1) move the limited VF drivers directly into the kernel tree,
> talk to them through a normal ops vector
> (2) get rid of the whole shim crap and instead integrate the limited
> VF driver with the full VF driver we already have, instead of
> duplicating the code
> (3) don't make the PV to VF integration VMware-specific but also
> provide an open reference implementation like virtio. We're not
> going to add massive amount of infrastructure that is not actually
> useable in a free software stack.

Let me put it bluntly. Any design that allows external code to run
in the kernel is not going to be accepted. Out of tree kernel modules are enough
of a pain already, why do you expect the developers to add another
interface.