From: Oliver Neukum <oneukum@suse.de>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"Jike Song" <albcamus@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drivers: code cleanups
Date: Wed, 14 Jul 2010 12:02:46 +0200 [thread overview]
Message-ID: <201007141202.46492.oneukum@suse.de> (raw)
In-Reply-To: <1279100576-8680-1-git-send-email-xiaosuo@gmail.com>
Am Mittwoch, 14. Juli 2010, 11:42:56 schrieb Changli Gao:
> drivers: code cleanups
>
> the first three goto clauses caused kfree(NULL), and the error code returned
> by kset->uevent_ops->uevent() wasn't passed to the caller of show_uevent().
> This patch also eliminates the unnecessary initializations of env and count.
This is not a good idea.
If you are indeed fixing a bug of not returning an error, make a patch that does that.
The other parts of your patch really are no improvement, because they make
things harder to maintain if additional cleanups or locking must ever be added.
Regards
Oliver
prev parent reply other threads:[~2010-07-14 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 9:42 [PATCH v2] drivers: code cleanups Changli Gao
2010-07-14 10:02 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007141202.46492.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=albcamus@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox