From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Pedro Ribeiro <pedrib@gmail.com>
Cc: eusou15@yahoo.com, ibm-acpi-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, toralf.foerster@gmx.de
Subject: Re: [PATCH] Remove 9 second reboot delay on Lenovo T400/T500
Date: Wed, 14 Jul 2010 15:36:25 +0100 [thread overview]
Message-ID: <20100714143625.GA30721@srcf.ucam.org> (raw)
In-Reply-To: <4C3DCAA4.9050602@gmail.com>
On Wed, Jul 14, 2010 at 03:33:08PM +0100, Pedro Ribeiro wrote:
> Please consider this patch. Let me know if you would like me to change
> anything or if you don't agree with it. It applies cleanly to 2.6.35-rc5.
>
> The Lenovo T400 and T500 have an annoying 9 second delay when
> rebooting, unless reboot=pci is passed to the kernel command line.
> This delay happens from at least kernel 2.6.20.
>
> Make this change permanent by hardcoding the Tx00 on the
> arch/kernel/reboot.c pci quirks table.
There's two possibilities here:
1) Lenovo's firmware is broken and the 9-second delay is always going to
be there. In that case we should try to use the ACPI reboot vector
first.
2) We're doing something wrong in our shutdown sequence which then
triggers this problem as a result.
Either way, I think this patch is wrong.
--
Matthew Garrett | mjg59@srcf.ucam.org
next parent reply other threads:[~2010-07-14 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C3DCAA4.9050602@gmail.com>
2010-07-14 14:36 ` Matthew Garrett [this message]
2010-07-14 14:46 ` [PATCH] Remove 9 second reboot delay on Lenovo T400/T500 Pedro Ribeiro
2010-07-14 15:26 ` Nick Bowler
2010-07-15 22:31 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2010-07-15 22:50 ` Matthew Garrett
2010-07-15 23:00 ` Henrique de Moraes Holschuh
2010-07-15 23:08 ` Matthew Garrett
2010-07-16 3:01 ` Henrique de Moraes Holschuh
2010-07-16 20:08 ` Matthew Garrett
2010-07-17 1:23 ` Henrique de Moraes Holschuh
2010-07-17 1:27 ` Matthew Garrett
2010-07-23 18:53 ` Pedro Ribeiro
2010-07-16 11:02 ` Pedro Ribeiro
2010-07-16 7:38 ` Jens Rutschmann
2010-07-16 20:31 ` Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714143625.GA30721@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=eusou15@yahoo.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pedrib@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox