RE: [PATCH v2 1/2] regulator: add support for regulators on the ab8500 MFD

Sundar R IYER
2010-07-13T14:35:13Z

Hello Mark,

>> + * @mask: mask to enable/disable regulator
>> + * @enable: bits to enable the regulator in normal(high power) mode
>Have you addressed my comments here?
Sorry that I couldn't inline my replies into the patch itself :(. I changed the comments for the variable
from the previous patch set. But I agree I messed up!

Yes. The mask here is different for the fact that we have two enable bits; enable LP(low power)
mode and enable HP(high power). We enable only the HP modes and hence the different mask
for enable/disable as well as for the enable.

>> + ret = ab8500_get_best_voltage_index(rdev, min_uV, max_uV);
>> + if (ret < 0) {
>> + dev_dbg(rdev_get_dev(rdev),
>> + "coudlnt get best voltage for regulator\n");
>
>Typo here. Also, shouldn't your error messages be errors rather than
>debug output?
Yes. I will correct this.