Re: [PATCH v2 2/2] ux500: add ab8500-regulators machine specific data

Mark Brown
2010-07-14T15:47:31Z

On Wed, Jul 14, 2010 at 09:06:44PM +0530, Sundar R IYER wrote:

> > Which datasheet, and will the system design actually be varying them at
> > runtime - if it will how will it do so? This is the settings for the

> I am referring to the AB8500 device data sheet; not sure if its
> available open. I have taken the minimal/maximum figures as what is
> mentioned for each supplies.

OK, you're missing the point here. The system constraints say what's
going to be used on this actual system not what an individual component
is capable of supporting. Regulators are almost always vastly more
flexible than any system can use and so the constraints are used to tell
the regulator core what configurations can be used on a given system.
You need to check what makes sense on the system for the things that are
connected.

> > Again, is it really the case that this will happen in this system?

> Yes, if you are referring to regulator enable/disable.

For *all* supplies?

> > Nothing is currently able to actually do that, and unless every consumer
> > using a given supply is hooked into the regulator API things will go
> > wrong when some of them start doing so.

> As i said earlier, my intention is to hard code the machine constraints.
> The actual control in terms of enable/disable, controlling supply
> voltages will happen, as you say when consumers are hooked up.

Again, you need to think about what's actually hooked up. Permission to
do any of this stuff depends heavily on the set of consumers that are
actually hooked up - think about the example I mentioned above where
some of the consumers on a shared supply are hooked up and doing enables
and disables, for example. What happens when they cause the supply to
be disabled but another consumer is running?