From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors
Date: Wed, 14 Jul 2010 14:28:36 -0400 [thread overview]
Message-ID: <20100714182836.GA12108@infradead.org> (raw)
In-Reply-To: <1279007450-10457-2-git-send-email-david@fromorbit.com>
Looks good, except that I'd rework the snipplet below
> status = xfs_buf_iorequest(bp);
> - if (!status && !(flags & XBF_ASYNC))
> + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> status = xfs_buf_iowait(bp);
> return status;
as:
if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
return status;
return xfs_buf_iowait(bp);
to make it a bit more clear.
next prev parent reply other threads:[~2010-07-14 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 7:50 [PATCH 0/2] Graceful failures for XFS on an unconfigured loop device Dave Chinner
2010-07-13 7:50 ` [PATCH 1/2] xfs: don't block on buffer read errors Dave Chinner
2010-07-14 18:28 ` Christoph Hellwig [this message]
2010-07-15 0:05 ` Dave Chinner
2010-07-13 7:50 ` [PATCH 2/2] blkdev: check for valid request queue before issuing flush Dave Chinner
2010-07-13 12:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714182836.GA12108@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).