From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Julia Lawall <julia@diku.dk>,
Frederic Weisbecker <fweisbec@gmail.com>,
John Kacur <jkacur@redhat.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: dpt_i2o: fix memory leak
Date: Wed, 14 Jul 2010 20:58:31 +0200 [thread overview]
Message-ID: <20100714185831.GA5164@bicker> (raw)
In-Reply-To: <1279130008-9934-1-git-send-email-segooon@gmail.com>
On Wed, Jul 14, 2010 at 09:53:27PM +0400, Kulikov Vasiliy wrote:
> Free allocated memory if adpt_ioctl_to_context() failed.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/scsi/dpt_i2o.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index f2d4df1..dd9a43b 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1839,8 +1839,10 @@ static int adpt_i2o_passthru(adpt_hba* pHba, u32 __user *arg)
> sg_offset = (msg[0]>>4)&0xf;
> msg[2] = 0x40000000; // IOCTL context
> msg[3] = adpt_ioctl_to_context(pHba, reply);
This patch is wrong I'm afraid. adpt_ioctl_to_context() frees "reply" if
there is an error.
regards,
dan carpenter
> - if (msg[3] == (u32)-1)
> + if (msg[3] == (u32)-1) {
> + kfree(reply);
> return -EBUSY;
> + }
>
> memset(sg_list,0, sizeof(sg_list[0])*pHba->sg_tablesize);
> if(sg_offset) {
> --
next prev parent reply other threads:[~2010-07-14 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 17:53 [PATCH] scsi: dpt_i2o: fix memory leak Kulikov Vasiliy
2010-07-14 18:58 ` Dan Carpenter [this message]
2010-07-14 19:05 ` Kulikov Vasiliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714185831.GA5164@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=aacraid@adaptec.com \
--cc=fweisbec@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jkacur@redhat.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox