linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
	peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com
Subject: Re: [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to rcutree_trace.c
Date: Wed, 14 Jul 2010 14:12:31 -0700	[thread overview]
Message-ID: <20100714211230.GA4624@feather> (raw)
In-Reply-To: <1279138204-12849-27-git-send-email-paulmck@linux.vnet.ibm.com>

On Wed, Jul 14, 2010 at 01:10:01PM -0700, Paul E. McKenney wrote:
> The print_rcu_pendings() function used the ->rda[] array, so this
> commit makes it instead use per_cpu_ptr().
> 
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
>  kernel/rcutree_trace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
> index 36c95b4..458e032 100644
> --- a/kernel/rcutree_trace.c
> +++ b/kernel/rcutree_trace.c
> @@ -262,7 +262,7 @@ static void print_rcu_pendings(struct seq_file *m, struct rcu_state *rsp)
>  	struct rcu_data *rdp;
>  
>  	for_each_possible_cpu(cpu) {
> -		rdp = rsp->rda[cpu];
> +		rdp = per_cpu_ptr(rsp->rda, cpu);
>  		if (rdp->beenonline)
>  			print_one_rcu_pending(m, rdp);
>  	}

For the final version of this patchset, this should get squashed into
the previous patch, right?  Otherwise, the state after the previous
patch but before this one won't compile.

- Josh Triplett

  reply	other threads:[~2010-07-14 21:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 20:09 [PATCH RFC tip/core/rcu 0/30] RCU commits queued for 2.6.36/7 Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 01/30] net: convert to rcu_dereference_index_check() Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 02/30] rcu: define __rcu address space modifier for sparse Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 03/30] rculist: avoid __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 04/30] cgroups: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 05/30] credentials: rcu annotation Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 06/30] keys: __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 07/30] nfs: " Paul E. McKenney
2010-07-14 22:07   ` Trond Myklebust
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 08/30] net: __rcu annotations for drivers Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 09/30] perf_event: __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 10/30] notifiers: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 11/30] radix-tree: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 12/30] idr: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 13/30] input: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 14/30] net/netfilter: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 15/30] kvm: add " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 16/30] kernel: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 17/30] net: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 18/30] kvm: more " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 19/30] vhost: add " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 20/30] Update documentation to note the passage of INIT_RCU_HEAD() Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 21/30] Update call_rcu() usage, add synchronize_rcu() Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 22/30] rcu: make CPU stall warning timeout configurable Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 23/30] rcu head remove init Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 24/30] rcu: add shiny new debug assists to Documentation/RCU/checklist.txt Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 25/30] rcutorture: add random preemption Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 26/30] rcu: simplify the usage of percpu data Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to rcutree_trace.c Paul E. McKenney
2010-07-14 21:12   ` Josh Triplett [this message]
2010-07-14 21:16     ` Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 28/30] rcu: rename __do_rcu_dereference_check() to rcu_lockdep_assert() Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 29/30] rcu: add boot parameter to suppress RCU CPU stall warning messages Paul E. McKenney
2010-07-14 21:16   ` Josh Triplett
2010-07-14 23:30     ` Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 30/30] rcu: improve kerneldoc for rcu_read_lock(), call_rcu(), and synchronize_rcu() Paul E. McKenney
2010-07-14 21:19 ` [PATCH RFC tip/core/rcu 0/30] RCU commits queued for 2.6.36/7 Josh Triplett
2010-07-14 23:27   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100714211230.GA4624@feather \
    --to=josh@joshtriplett.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).