From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754903Ab0GOHTr (ORCPT ); Thu, 15 Jul 2010 03:19:47 -0400 Received: from bld-mail19.adl2.internode.on.net ([150.101.137.104]:33583 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753588Ab0GOHTq (ORCPT ); Thu, 15 Jul 2010 03:19:46 -0400 Date: Thu, 15 Jul 2010 17:18:42 +1000 From: Dave Chinner To: Andrew Morton Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Christoph Hellwig , Jens Axboe , Al Viro Subject: Re: linux-next: Tree for July 7 Message-ID: <20100715071842.GH30737@dastard> References: <20100707165539.957e7d1c.sfr@canb.auug.org.au> <20100707172136.3658fb17.akpm@linux-foundation.org> <20100714152042.5b83f03b.akpm@linux-foundation.org> <20100715094513.8941fa25.sfr@canb.auug.org.au> <20100714172741.f520b7a3.akpm@linux-foundation.org> <20100715004639.GG30737@dastard> <20100714175345.0721abb7.akpm@linux-foundation.org> <20100715021237.GB23223@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100715021237.GB23223@dastard> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2010 at 12:12:37PM +1000, Dave Chinner wrote: > On Wed, Jul 14, 2010 at 05:53:45PM -0700, Andrew Morton wrote: > > On Thu, 15 Jul 2010 10:46:39 +1000 Dave Chinner wrote: > > > On Wed, Jul 14, 2010 at 05:27:41PM -0700, Andrew Morton wrote: > > > > On Thu, 15 Jul 2010 09:45:13 +1000 Stephen Rothwell wrote: > > > > > Hi Andrew, Al, > > > > > On Wed, 14 Jul 2010 15:20:42 -0700 Andrew Morton wrote: > > > > > > Bug is still there. Reverting ""Make ->drop_inode() just return > > > > > > whether inode needs to be dropped" makes it go away. > > > > > > > > > > > > Al, please don't just dump crap in linux-next and then ignore bug reports. > > > > > > People are trying to get work done here. > > > > > > > > > > I will revert that commit in linux-next today if it is still there (and > > > > > not fixed). > > > > > > > > Reverting the patch didn't help - the patch moved the BUG_ON() from > > > > generic_delete_inode() into __iput_final(). With the patch reverted > > > > the kernel still goes BUG over the same test in generic_delete_inode(). > > > > > > > > It could be that the bug was caused by fs-writeback.c changes. David, > > > > do you have time to take a look at this? > > > > > What filesystem(s) are you seeing this on? > > > > ext3 at least. > > > > > Any particular workload that triggers it? > > > > Booting FC6 :( I get an enormous storm of these things. > > > > whee, progress! > > > > With Rusty's patch for the modules bug, and reverting Greg > > Vandal-Hartman's "driver core: remove CONFIG_SYSFS_DEPRECATED" and > > deleting the BUG_ON from generic_delete_inode(), I have a login prompt! > > Admittedly I don't have any networking any more, but that seems a > > minor quibble. > > I just booted an unmodified current linux-next tree with my standard > config and it's come up on an ext3 root and running xfsqa on XFS > without any problems so far. I'm going to try your config from your > original bug report and see if that generates the problem... I've had a couple of VMs running all afternoon trying to trigger this on current linux-next kernels and different filesystems, but I have not seen any problems. So I'm afraid I'm can't do much to help you solve the problem right now, Andrew. Do you have any ideas that might help reproduce it? Cheers, Dave. -- Dave Chinner david@fromorbit.com