From: Greg KH <greg@kroah.com>
To: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Cc: James Morris <jmorris@namei.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH][securityfs][2.6.34] Drop dentry reference count when mknod fails
Date: Thu, 15 Jul 2010 10:10:51 -0700 [thread overview]
Message-ID: <20100715171051.GA21798@kroah.com> (raw)
In-Reply-To: <201007151325.06942.tvrtko.ursulin@sophos.com>
On Thu, Jul 15, 2010 at 01:25:06PM +0100, Tvrtko Ursulin wrote:
>
> lookup_one_len increments dentry reference count which is not decremented
> when the create operation fails. This can cause a kernel BUG at
> fs/dcache.c:676 at unmount time. Also error code returned when new_inode()
> fails was replaced with more appropriate -ENOMEM.
>
Nice, thanks for finding and fixing this, great job.
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-15 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 12:25 [PATCH][securityfs][2.6.34] Drop dentry reference count when mknod fails Tvrtko Ursulin
2010-07-15 14:59 ` Serge E. Hallyn
2010-07-15 17:10 ` Greg KH [this message]
2010-07-16 1:38 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715171051.GA21798@kroah.com \
--to=greg@kroah.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tvrtko.ursulin@sophos.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox