From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933870Ab0GORLt (ORCPT ); Thu, 15 Jul 2010 13:11:49 -0400 Received: from kroah.org ([198.145.64.141]:51586 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933757Ab0GORLq (ORCPT ); Thu, 15 Jul 2010 13:11:46 -0400 Date: Thu, 15 Jul 2010 10:10:51 -0700 From: Greg KH To: Tvrtko Ursulin Cc: James Morris , Al Viro , "linux-kernel@vger.kernel.org" , linux-security-module@vger.kernel.org Subject: Re: [PATCH][securityfs][2.6.34] Drop dentry reference count when mknod fails Message-ID: <20100715171051.GA21798@kroah.com> References: <201007151325.06942.tvrtko.ursulin@sophos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201007151325.06942.tvrtko.ursulin@sophos.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2010 at 01:25:06PM +0100, Tvrtko Ursulin wrote: > > lookup_one_len increments dentry reference count which is not decremented > when the create operation fails. This can cause a kernel BUG at > fs/dcache.c:676 at unmount time. Also error code returned when new_inode() > fails was replaced with more appropriate -ENOMEM. > Nice, thanks for finding and fixing this, great job. > Signed-off-by: Tvrtko Ursulin Acked-by: Greg Kroah-Hartman thanks, greg k-h