From: Frederic Weisbecker <fweisbec@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Soeren Sandmann <sandmann@daimi.au.dk>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC PATCH 2/2] tracing: Remove special traces
Date: Fri, 16 Jul 2010 05:02:16 +0200 [thread overview]
Message-ID: <20100716030214.GB6417@nowhere> (raw)
In-Reply-To: <4C3FAD44.1050900@cn.fujitsu.com>
On Fri, Jul 16, 2010 at 08:52:20AM +0800, Li Zefan wrote:
> > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > index 2114b4c..2f8619b 100644
> > --- a/kernel/trace/trace.h
> > +++ b/kernel/trace/trace.h
> > @@ -22,7 +22,6 @@ enum trace_type {
> > TRACE_STACK,
> > TRACE_PRINT,
> > TRACE_BPRINT,
> > - TRACE_SPECIAL,
> > TRACE_MMIO_RW,
> > TRACE_MMIO_MAP,
> > TRACE_BRANCH,
> > @@ -332,11 +331,6 @@ void tracing_sched_wakeup_trace(struct trace_array *tr,
> > struct task_struct *wakee,
> > struct task_struct *cur,
> > unsigned long flags, int pc);
> > -void trace_special(struct trace_array *tr,
> > - struct trace_array_cpu *data,
> > - unsigned long arg1,
> > - unsigned long arg2,
> > - unsigned long arg3, int pc);
> > void trace_function(struct trace_array *tr,
> > unsigned long ip,
> > unsigned long parent_ip,
>
> You forgot to delete this:
>
> IF_ASSIGN(var, ent, struct special_entry, 0); \
Oops, right, I forgot that. And I forgot to Cc you as well, sorry.
Will fix, thanks.
next prev parent reply other threads:[~2010-07-16 3:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 23:36 [RFC PATCH 0/2] tracing: Remove sysprof Frederic Weisbecker
2010-07-15 23:36 ` [RFC PATCH 1/2] tracing: Remove sysprof ftrace plugin Frederic Weisbecker
2010-07-15 23:36 ` [RFC PATCH 2/2] tracing: Remove special traces Frederic Weisbecker
2010-07-16 0:52 ` Li Zefan
2010-07-16 3:02 ` Frederic Weisbecker [this message]
2010-07-17 5:28 ` [RFC PATCH 0/2] tracing: Remove sysprof Soeren Sandmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716030214.GB6417@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sandmann@daimi.au.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox