From: Greg KH <gregkh@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Peter Huewe <PeterHuewe@gmx.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
"Digi International, Inc" <Eng.Linux@digi.com>,
Alexey Dobriyan <adobriyan@gmail.com>, Tejun Heo <tj@kernel.org>,
Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Date: Thu, 15 Jul 2010 22:29:24 -0700 [thread overview]
Message-ID: <20100716052924.GA29966@suse.de> (raw)
In-Reply-To: <1279255463.4526.19.camel@Joe-Laptop.home>
On Thu, Jul 15, 2010 at 09:44:23PM -0700, Joe Perches wrote:
> On Thu, 2010-07-15 at 21:29 -0700, Greg KH wrote:
> > On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote:
> > > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote:
> > > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not
> > > > willing to take any of these patches, sorry.
> > > grepping for pci device ids using constants and
> > > expecting the result to be comprehensive isn't
> > > sensible.
> > But it's a nice goal :)
>
> I think your goal is not a good one.
>
> For instance:
>
> $ grep -rP --include=*.[ch] "\bPCI_VDEVICE\s*\(\s*INTEL" drivers | wc -l
> 201
> $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(PCI_VENDOR_ID_INTEL" drivers | wc -l
> 45
> $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(\s*0x8086" drivers | wc -l
> 38
>
> I'd much rather do a search for "PCI_VDEVICE.*INTEL"
I'd much rather use 'cscope' or 'ctags' than trying to remember regular
expressions like the above.
greg k-h
next prev parent reply other threads:[~2010-07-16 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:52 [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Peter Huewe
2010-07-15 20:45 ` Greg KH
2010-07-15 21:00 ` Joe Perches
2010-07-16 4:29 ` Greg KH
2010-07-16 4:44 ` Joe Perches
2010-07-16 5:29 ` Greg KH [this message]
2010-07-16 5:37 ` Joe Perches
2010-07-16 5:47 ` Greg KH
2010-07-15 21:07 ` Peter Hüwe
2010-07-16 4:28 ` Greg KH
2010-07-16 23:54 ` Peter Hüwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716052924.GA29966@suse.de \
--to=gregkh@suse.de \
--cc=Eng.Linux@digi.com \
--cc=PeterHuewe@gmx.de \
--cc=adobriyan@gmail.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox