Re: Testing of function/data-sections on linux-2.6.35-rc4

Sam Ravnborg
2010-07-26T07:27:13Z

On Mon, Jul 26, 2010 at 03:29:09AM +0200, Denys Vlasenko wrote:
> On Friday 23 July 2010 22:24, Sam Ravnborg wrote:
> > > * fix for kernel linker stripts: linux-2.6.35-rc4-fs.fix-kernel-linker-scripts.patch
> > > It makes _all_ linker scripts -ffunction/data-sections safe via:
> > > - *(.data)
> > > + *(.data .data.*)
> > >
> >
> > This patch touches both the regular kernel linker scripts and the
> > boot linker scripts.
> > I would strongly prefer a split so you touched the boot linker
> > scripts in a separate patch.
>
> No problem.
>
> > In addition the patch handles more sections than
> > documented: rodata, bss, text.
>
> Yes, that was assumed.
>
> > The patch introduce the following syntax for input sections:
> >
> > *(.bss .bss.*)
> >
> > Where the kernel linker script would have one input
> > section per line.
> > Can we stick to the "layout" used in the kernel linker scripts?
>
> Sure.
>
>
> > The patch in addition in several places changes linker
> > scripts that already uses the two-lines layout to a single line approach.
> > These "fixes" should be omitted.
>
> Reverted.
>
> > Why do we need *(.bss .bss.*)?
> > Does -fdata-sections introduce special .bss sectiosn too?
>
> Yes, it does.
>
> Please take a look at attached updated patches.
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

Looks better now - thanks.

With proper changelogs both patches has my:

Acked-by: Sam Ravnborg <sam@ravnborg.org>

Sam