From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: vgoyal@redhat.com, "David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
seto.hidetoshi@jp.fujitsu.com,
Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH repost] pci: fix compilation when CONFIG_PCI_MSI=n
Date: Mon, 19 Jul 2010 13:42:02 +0300 [thread overview]
Message-ID: <20100719104202.GA32031@redhat.com> (raw)
In-Reply-To: <20100716120603.5c3de0bd@virtuousgeek.org>
On Fri, Jul 16, 2010 at 12:06:03PM -0700, Jesse Barnes wrote:
> On Fri, 16 Jul 2010 17:20:50 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > vers/pci/pci.c:2277: error: redefinition of ‘pci_msi_off’
> > include/linux/pci.h:786: note: previous definition of ‘pci_msi_off’ was here
> >
> > No need for ifdef: we must disable the capability at startup even if the
> > current kernel does not support MSI, otherwise the device won't work.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Looks like I didn't tag this old patch of mine clearly enough
> > so it's still not fixed in -rc5.
> > It's late in the cycle, but the patch is trivial
> > and it's a build fix, so ... please consider for 2.6.35.
>
> I don't see the same context in the current tree. So this patch must
> be against the virtualization tree I guess?
Yes, looks like it got fixed in the virtualization tree.
Thanks,
MST
prev parent reply other threads:[~2010-07-19 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 14:20 [PATCH repost] pci: fix compilation when CONFIG_PCI_MSI=n Michael S. Tsirkin
2010-07-16 15:50 ` Jesse Barnes
2010-07-16 19:06 ` Jesse Barnes
2010-07-19 10:42 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719104202.GA32031@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=rjw@sisk.pl \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox