Re: [PATCH] i2c: cyttsp i2c and spi touchscreen driver init submit

Henrik Rydberg
2010-08-05T23:07:31Z

On 08/05/2010 08:12 PM, Kevin McNeely wrote:

> From: Fred <fwk@ubuntu.linuxcertified.com>
>
> This is a new touchscreen driver for the Cypress Semiconductor
> cyttsp family of devices. This updated driver is for both the i2c and spi
> versions of the devices. The driver code consists of common core code for
> both i2c and spi driver. This submission is in response to review comments
> from the initial submission.
>
> Signed-off-by: Kevin McNeely <kev@cypress.com>
> ---

General impression: There is a lot of useful code in here, but as already
pointed out, well over half of it should not be part of the kernel driver.

Suggestion 1: Clean out the internal state code and use MT protocol B instead.

Suggestion 2: Cut out the single touch calculation, as already pointed out by
Trilok. Why not submit it to the mtdev project instead? The problem is generic
to all new MT drivers, so a common solution while waiting for full MT support in
userspace could be useful.

Thanks,
Henrik