Re: [PATCH 0/3] padata: cpumasks

Herbert Xu
2010-07-19T07:33:17Z

On Mon, Jul 19, 2010 at 08:40:50AM +0200, Steffen Klassert wrote:
> On Mon, Jul 19, 2010 at 02:04:26PM +0800, Herbert Xu wrote:
> >
> > All applied. Thanks!
>
> Hm, I was just about to write some comments on these patches,
> they still have some issues. For example, handling empty cpumasks
> is broken again (NULL pointer dereference in padata_replace).
> The cpu_index is zero for all cpus now, so can we leak objects
> on cpu hotplug etc. Also I'm not that happy with some of the
> API changes. I'll try to fix this up with some patches.

OK I'll take your fixes on top when you're ready.

Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt