From: Vivek Goyal <vgoyal@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
Corrado Zoccolo <czoccolo@gmail.com>,
axboe@kernel.dk, Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] cfq-iosched: fixing RQ_NOIDLE handling.
Date: Tue, 20 Jul 2010 10:26:48 -0400 [thread overview]
Message-ID: <20100720142647.GA8967@redhat.com> (raw)
In-Reply-To: <20100720141102.GA6316@infradead.org>
On Tue, Jul 20, 2010 at 10:11:03AM -0400, Christoph Hellwig wrote:
> Didn't you guys have a previous iteration of the fixes that gets
> rid of REQ_NODILE by improving the heuristics inside cfq? That
> would be much, much preffered from the filesystem point of view.
Actually in this patch, I was thinking we can probably get rid of
RQ_NOIDLE flag and just check for WRITE_SYNC. Any WRITE_SYNC queue
gets served on sync-noidle tree. I am wondering will we not face jbd
thread issues with direct writes also? If yes, then not special casing
direct IO writes and treat them same as O_SYNC writes will make sense.
I really wished that we had some blktrace of some standard workloads
stored somewhere which we could simply replay using "btreplay" and come
to some kind of conclusion whenever we are faced with taking such
decisions.
Thanks
Vivek
next prev parent reply other threads:[~2010-07-20 14:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 15:22 [PATCH 0/2] cfq-iosched: fixing RQ_NOIDLE handling Corrado Zoccolo
2010-07-07 15:56 ` Corrado Zoccolo
2010-07-07 17:03 ` Jeff Moyer
2010-07-07 17:39 ` Corrado Zoccolo
2010-07-07 20:06 ` Jeff Moyer
2010-07-08 14:38 ` Corrado Zoccolo
2010-07-09 10:33 ` Corrado Zoccolo
2010-07-09 13:23 ` Vivek Goyal
2010-07-09 14:07 ` Jeff Moyer
2010-07-09 19:45 ` Corrado Zoccolo
2010-07-09 20:48 ` Jeff Moyer
2010-07-13 19:38 ` Jeff Moyer
2010-07-13 19:56 ` Vivek Goyal
2010-07-13 20:30 ` Jeff Moyer
2010-07-13 20:42 ` Vivek Goyal
2010-07-19 16:08 ` Jeff Moyer
2010-07-19 20:31 ` Vivek Goyal
2010-07-20 14:02 ` Jeff Moyer
2010-07-20 14:11 ` Christoph Hellwig
2010-07-20 14:26 ` Vivek Goyal [this message]
2010-07-20 19:10 ` Corrado Zoccolo
2010-07-20 19:32 ` Vivek Goyal
2010-07-13 21:00 ` Jeff Moyer
2010-07-07 17:50 ` Vivek Goyal
2010-07-08 14:35 ` Vivek Goyal
2010-07-08 14:38 ` Jeff Moyer
2010-07-08 14:45 ` Corrado Zoccolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720142647.GA8967@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=czoccolo@gmail.com \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox