public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Geoffrey Wossum <gwossum@acm.org>,
	vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 2/3] sound/soc/atmel: Remove dead CONFIG_AT32_ENHANCED_PORTMUX
Date: Wed, 21 Jul 2010 13:50:29 +0100	[thread overview]
Message-ID: <20100721125029.GB15462@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <d2382c03db1d5b41a857b67688bf32838993d137.1279708102.git.qy03fugy@stud.informatik.uni-erlangen.de>

On Wed, Jul 21, 2010 at 02:35:41PM +0200, Christian Dietrich wrote:
> CONFIG_AT32_ENCHANCED_PORTMUX doesn't exist in Kconfig or somewhere
> else, therefore removing all references for it from the source code.
> 
> Signed-off-by: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>

Please remember to CC maintainers on patches - I've added Geoffrey.

> ---
>  sound/soc/atmel/playpaq_wm8510.c |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/sound/soc/atmel/playpaq_wm8510.c b/sound/soc/atmel/playpaq_wm8510.c
> index 9df4c68..fbd17e9 100644
> --- a/sound/soc/atmel/playpaq_wm8510.c
> +++ b/sound/soc/atmel/playpaq_wm8510.c
> @@ -425,11 +425,6 @@ static int __init playpaq_asoc_init(void)
>  	clk_set_rate(CODEC_CLK, 12000000);
>  	clk_enable(CODEC_CLK);
>  
> -#if defined CONFIG_AT32_ENHANCED_PORTMUX
> -	at32_select_periph(MCLK_PIN, MCLK_PERIPH, 0);
> -#endif
> -
> -
>  	/*
>  	 * Create and register platform device
>  	 */
> @@ -496,10 +491,6 @@ static void __exit playpaq_asoc_exit(void)
>  		_pll0 = NULL;
>  	}
>  
> -#if defined CONFIG_AT32_ENHANCED_PORTMUX
> -	at32_free_pin(MCLK_PIN);
> -#endif
> -
>  	platform_device_unregister(playpaq_snd_device);
>  	playpaq_snd_device = NULL;
>  }
> -- 
> 1.7.0.4
> 

  reply	other threads:[~2010-07-21 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 12:34 [PATCH 0/3] Removing dead code Christian Dietrich
2010-07-21 12:35 ` [PATCH 1/3] sound/oss: Remove dead CONFIG_SOFTOSS* Christian Dietrich
2010-07-21 13:03   ` Takashi Iwai
2010-07-21 12:35 ` [PATCH 2/3] sound/soc/atmel: Remove dead CONFIG_AT32_ENHANCED_PORTMUX Christian Dietrich
2010-07-21 12:50   ` Mark Brown [this message]
2010-07-21 12:36 ` [PATCH 3/3] sound/isa/gus: Remove dead CONFIG_SND_DEBUG_ROM Christian Dietrich
2010-07-21 12:57   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100721125029.GB15462@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=gwossum@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=perex@perex.cz \
    --cc=qy03fugy@stud.informatik.uni-erlangen.de \
    --cc=tiwai@suse.de \
    --cc=vamos-dev@i4.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox