From: Greg KH <gregkh@suse.de>
To: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>
Cc: Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ben Blum <bblum@andrew.cmu.edu>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on
Date: Thu, 22 Jul 2010 11:26:38 -0700 [thread overview]
Message-ID: <20100722182638.GA12712@kroah.com> (raw)
We really shouldn't be asking userspace to create new root filesystems.
So follow along with all of the other in-kernel filesystems, and provide
a mount point in sysfs.
For cgroupfs, this should be in /sys/fs/cgroup/ This change provides
that mount point when the cgroup filesystem is registered in the kernel.
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Lennart Poettering <lennart@poettering.net>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1623,6 +1623,8 @@ static struct file_system_type cgroup_fs_type = {
.kill_sb = cgroup_kill_sb,
};
+static struct kobject *cgroup_kobj;
+
static inline struct cgroup *__d_cgrp(struct dentry *dentry)
{
return dentry->d_fsdata;
@@ -3871,9 +3873,18 @@ int __init cgroup_init(void)
hhead = css_set_hash(init_css_set.subsys);
hlist_add_head(&init_css_set.hlist, hhead);
BUG_ON(!init_root_id(&rootnode));
+
+ cgroup_kobj = kobject_create_and_add("cgroup", fs_kobj);
+ if (!cgroup_kobj) {
+ err = -ENOMEM;
+ goto out;
+ }
+
err = register_filesystem(&cgroup_fs_type);
- if (err < 0)
+ if (err < 0) {
+ kobject_put(cgroup_kobj);
goto out;
+ }
proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);
next reply other threads:[~2010-07-22 18:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 18:26 Greg KH [this message]
2010-07-22 18:31 ` [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on Paul Menage
2010-07-22 18:36 ` Greg KH
2010-07-22 18:44 ` Paul Menage
2010-07-22 18:53 ` Greg KH
2010-07-22 19:07 ` Paul Menage
2010-07-22 19:12 ` Greg KH
2010-07-22 19:18 ` Paul Menage
2010-07-22 21:19 ` Greg KH
2010-07-22 23:12 ` Paul Menage
2010-07-22 23:20 ` Greg KH
2010-07-22 21:48 ` Matt Helsley
2010-07-22 23:10 ` Kay Sievers
2010-07-23 20:21 ` Matt Helsley
2010-07-22 19:37 ` Vivek Goyal
2010-07-22 21:18 ` Greg KH
2010-07-22 21:26 ` Vivek Goyal
2010-07-22 23:35 ` Greg KH
2010-07-24 14:15 ` Balbir Singh
2010-07-22 23:08 ` Kay Sievers
2010-07-22 23:14 ` Greg KH
2010-07-22 23:16 ` Paul Menage
2010-07-22 23:23 ` Kay Sievers
2010-07-23 2:07 ` Vivek Goyal
2010-07-23 10:32 ` Jan Safranek
2010-07-23 12:06 ` Greg KH
2010-07-26 9:08 ` Dhaval Giani
2010-07-26 9:12 ` Kay Sievers
2010-07-26 9:13 ` Dhaval Giani
2010-07-26 21:28 ` Greg KH
2010-07-26 21:55 ` Paul Menage
2010-07-26 22:05 ` Greg KH
2010-07-26 22:08 ` Dhaval Giani
2010-07-26 22:17 ` Greg KH
2010-07-26 22:09 ` Paul Menage
2010-07-26 22:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722182638.GA12712@kroah.com \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bblum@andrew.cmu.edu \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kay.sievers@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox