[PATCH v2] Staging: dt3155: make local variables static

[PATCH v2] Staging: dt3155: make local variables static

[H Hartley Sweeten]

The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
static variables do not need initialization so remove them. While here, also
move the definition for allocatorAddr so that all the variables are declared at
one place in the code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Scott Smedley <ss@aao.gov.au>
Cc: Joe Perches <joe@perches.com>

---

diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
index 9e7b880..da02741 100644
--- a/drivers/staging/dt3155/dt3155_drv.c
+++ b/drivers/staging/dt3155/dt3155_drv.c
@@ -112,20 +112,14 @@ int dt3155_major = 0;
 struct dt3155_status dt3155_status[MAXBOARDS];
 
 /* kernel logical address of the board */
-static void __iomem *dt3155_lbase[MAXBOARDS] = { NULL
-#if MAXBOARDS == 2
-				      , NULL
-#endif
-};
+static void __iomem *dt3155_lbase[MAXBOARDS];
 
-u32  dt3155_dev_open[MAXBOARDS] = {0
-#if MAXBOARDS == 2
-				       , 0
-#endif
-};
+static u32  dt3155_dev_open[MAXBOARDS];
 
 u32  ndevices = 0;
-u32 unique_tag = 0;;
+static u32 unique_tag;
+
+static u32 allocatorAddr;
 
 
 /*
@@ -937,9 +931,6 @@ err:
   return -EIO;
 }
 
-u32 allocatorAddr = 0;
-
-
 int dt3155_init(void)
 {
   struct dt3155_status *dts;

Re: [PATCH v2] Staging: dt3155: make local variables static

[Greg KH]

On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote:
> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
> static variables do not need initialization so remove them. While here, also
> move the definition for allocatorAddr so that all the variables are declared at
> one place in the code.

This doesn't apply after applying your previous patch to this file :(

thanks,

greg k-h

RE: [PATCH v2] Staging: dt3155: make local variables static

[H Hartley Sweeten]

On Monday, July 26, 2010 3:35 PM, Greg KH wrote:
> On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote:
>> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
>> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
>> static variables do not need initialization so remove them. While here, also
>> move the definition for allocatorAddr so that all the variables are declared at
>> one place in the code.
>
> This doesn't apply after applying your previous patch to this file :(

Oops.. I'll fix it up and repost.

Regards,
Hartley