From: Arjan van de Ven <arjan@infradead.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: torvalds@linux-foundation.org, dmitry.torokhov@gmail.com
Subject: Re: Input: twl40300-keypad - fix handling of "all ground" rows
Date: Sat, 24 Jul 2010 08:05:51 -0700 [thread overview]
Message-ID: <20100724080551.22893752@infradead.org> (raw)
In-Reply-To: <201007221959.o6MJx9VQ023618@hera.kernel.org>
On Thu, 22 Jul 2010 19:59:09 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> Gitweb:
> http://git.kernel.org/linus/3fea60261e73dbf4a51130d40cafcc8465b0f2c3
> Commit: 3fea60261e73dbf4a51130d40cafcc8465b0f2c3 Parent:
> c25f7b763cc35a249232ce612a36a811b0e263f9 Author: Dmitry Torokhov
> <dmitry.torokhov@gmail.com> AuthorDate: Tue Jul 20 20:25:35 2010 -0700
> Committer: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CommitDate: Tue Jul 20 20:29:48 2010 -0700
>
> Input: twl40300-keypad - fix handling of "all ground" rows
>
> The Nokia RX51 board code
> (arch/arm/mach-omap2/board-rx51-peripherals.c) defines a key map for
> the matrix keypad keyboard. The hardware seems to use all of the 8
> rows and 8 columns of the keypad, although not all possible locations
> are used.
> + KEY(4, 8, KEY_10),
> +
> KEY(5, 0, KEY_Y),
> + KEY(5, 8, KEY_11),
>
This patch, as merged, is broken. Nowhere in the kernel are KEY_10 and
KEY_11 defined.... so this causes a compile failure.
Are you sure you didn't mean KEY_F10 / KEY_F11 ?
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next parent reply other threads:[~2010-07-24 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201007221959.o6MJx9VQ023618@hera.kernel.org>
2010-07-24 15:05 ` Arjan van de Ven [this message]
2010-07-26 8:12 ` Input: twl40300-keypad - fix handling of "all ground" rows Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724080551.22893752@infradead.org \
--to=arjan@infradead.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox