* linux-next: build failure after merge of the mips tree
@ 2010-07-27 1:14 Stephen Rothwell
2010-07-27 2:32 ` [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740 Lars-Peter Clausen
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-07-27 1:14 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-next, linux-kernel, Lars-Peter Clausen
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Hi Ralf,
After merging the xtensa tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/video/jz4740_fb.c:29:39: error: asm/mach-jz4740/jz4740_fb.h: No such file or directory
drivers/video/jz4740_fb.c:30:34: error: asm/mach-jz4740/gpio.h: No such file or directory
drivers/video/jz4740_fb.c:149: error: array type has incomplete element type
drivers/video/jz4740_fb.c:150: error: implicit declaration of function 'JZ_GPIO_BULK_PIN'
drivers/video/jz4740_fb.c:150: error: 'LCD_PCLK' undeclared here (not in a function)
... and on and on ...
Caused by commit e457478bc296ea3f2ae51ca7c165a59621c1655d ("FBDEV:
JZ4740: Add framebuffer driver"). Presumably this driver will only build
on MIPS?
I have used the mips tree from next-20100726 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740
2010-07-27 1:14 linux-next: build failure after merge of the mips tree Stephen Rothwell
@ 2010-07-27 2:32 ` Lars-Peter Clausen
2010-07-27 5:55 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2010-07-27 2:32 UTC (permalink / raw)
To: Ralf Baechle
Cc: Stephen Rothwell, linux-next, linux-kernel, Lars-Peter Clausen
The jz4740-fb driver should only be selectabed of MACH_JZ4740 is selected.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/video/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index a42cb9b..9e711a1 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2231,7 +2231,7 @@ config FB_BROADSHEET
config FB_JZ4740
tristate "JZ4740 LCD framebuffer support"
- depends on FB
+ depends on FB && MACH_JZ4740
select FB_SYS_FILLRECT
select FB_SYS_COPYAREA
select FB_SYS_IMAGEBLIT
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740
2010-07-27 2:32 ` [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740 Lars-Peter Clausen
@ 2010-07-27 5:55 ` Ralf Baechle
2010-07-28 1:31 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Baechle @ 2010-07-27 5:55 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Tue, Jul 27, 2010 at 04:32:59AM +0200, Lars-Peter Clausen wrote:
> The jz4740-fb driver should only be selectabed of MACH_JZ4740 is selected.
Thanks, folded into the original patch.
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740
2010-07-27 5:55 ` Ralf Baechle
@ 2010-07-28 1:31 ` Stephen Rothwell
2010-07-28 2:14 ` Stephen Rothwell
2010-07-28 2:35 ` Ralf Baechle
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-07-28 1:31 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Lars-Peter Clausen, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Hi Ralf,
On Tue, 27 Jul 2010 06:55:46 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:
>
> On Tue, Jul 27, 2010 at 04:32:59AM +0200, Lars-Peter Clausen wrote:
>
> > The jz4740-fb driver should only be selectabed of MACH_JZ4740 is selected.
>
> Thanks, folded into the original patch.
But it didn't make it into your mips-for-linux-next branch today?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740
2010-07-28 1:31 ` Stephen Rothwell
@ 2010-07-28 2:14 ` Stephen Rothwell
2010-07-28 2:35 ` Ralf Baechle
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-07-28 2:14 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Lars-Peter Clausen, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
Hi Ralf,
On Wed, 28 Jul 2010 11:31:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 27 Jul 2010 06:55:46 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:
> >
> > On Tue, Jul 27, 2010 at 04:32:59AM +0200, Lars-Peter Clausen wrote:
> >
> > > The jz4740-fb driver should only be selectabed of MACH_JZ4740 is selected.
> >
> > Thanks, folded into the original patch.
>
> But it didn't make it into your mips-for-linux-next branch today?
I will apply that patch myself just for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740
2010-07-28 1:31 ` Stephen Rothwell
2010-07-28 2:14 ` Stephen Rothwell
@ 2010-07-28 2:35 ` Ralf Baechle
1 sibling, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2010-07-28 2:35 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Lars-Peter Clausen, linux-next, linux-kernel
On Wed, Jul 28, 2010 at 11:31:36AM +1000, Stephen Rothwell wrote:
> On Tue, 27 Jul 2010 06:55:46 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:
> >
> > On Tue, Jul 27, 2010 at 04:32:59AM +0200, Lars-Peter Clausen wrote:
> >
> > > The jz4740-fb driver should only be selectabed of MACH_JZ4740 is selected.
> >
> > Thanks, folded into the original patch.
>
> But it didn't make it into your mips-for-linux-next branch today?
Fixed. Sorry.
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-28 2:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-27 1:14 linux-next: build failure after merge of the mips tree Stephen Rothwell
2010-07-27 2:32 ` [PATCH] fbdev: Make jz4740-fb depends on MACH_JZ4740 Lars-Peter Clausen
2010-07-27 5:55 ` Ralf Baechle
2010-07-28 1:31 ` Stephen Rothwell
2010-07-28 2:14 ` Stephen Rothwell
2010-07-28 2:35 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox