From: Robert Richter <robert.richter@amd.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Peter Zijlstra <peterz@infradead.org>, Greg KH <greg@kroah.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Mundt <lethal@linux-sh.org>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Will Deacon <will.deacon@arm.com>,
Maynard Johnson <mpjohn@us.ibm.com>, Carl Love <carll@us.ibm.com>,
Kay Sievers <kay.sievers@vrfy.org>,
lkml <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH v1 02/15] perf: export generic hardware events via sysfs
Date: Tue, 27 Jul 2010 10:27:49 +0200 [thread overview]
Message-ID: <20100727082749.GK26154@erda.amd.com> (raw)
In-Reply-To: <1280197103.24607.61.camel@minggr.sh.intel.com>
On 26.07.10 22:18:23, Lin Ming wrote:
> > > /sys/devices/system/cpu/cpu0/events
> > > |-- L1-dcache-load-misses
> > > | |-- config
> > > | `-- type
vs.
> > |-- L1-dcache-load-misses ===> event name
> > | `-- id ===> event id
> > This is very simple and flexible and solves the original problem too.
>
> Yeah, this is flexible. I'll think about this closely.
The thing is, if you start introducing the config/type i/f, we will
stick with it for a long time. I want to avoid this from the
beginning.
Using an id only would work with your current implementation too, you
only need to maintain an id -> config/type mapping, maybe in some
private data section, without exporting it to userspace.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2010-07-27 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 11:12 [RFC][PATCH v1 02/15] perf: export generic hardware events via sysfs Lin Ming
2010-07-23 10:44 ` Robert Richter
2010-07-27 2:18 ` Lin Ming
2010-07-27 8:27 ` Robert Richter [this message]
2010-07-27 17:51 ` Corey Ashford
2010-07-28 10:02 ` Robert Richter
2010-07-29 3:29 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727082749.GK26154@erda.amd.com \
--to=robert.richter@amd.com \
--cc=Gary.Mohr@bull.com \
--cc=acme@redhat.com \
--cc=arjan@linux.intel.com \
--cc=carll@us.ibm.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=mpjohn@us.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox