From: Rabin Vincent <rabin@rab.in>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk,
akpm@linux-foundation.org, a.zummo@towertech.it,
gortmaker@yahoo.com, kyungmin.park@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/3] rtc: Add MAX8998 rtc driver
Date: Tue, 27 Jul 2010 20:22:47 +0530 [thread overview]
Message-ID: <20100727145247.GA23448@debian> (raw)
In-Reply-To: <1279609058-32319-3-git-send-email-jy0922.shim@samsung.com>
On Tue, Jul 20, 2010 at 03:57:38PM +0900, Joonyoung Shim wrote:
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 7e4489f..0612851 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -30,9 +30,12 @@
> #include <linux/mfd/max8998.h>
> #include <linux/mfd/max8998-private.h>
>
> +#define RTC_I2C_ADDR (0x0c >> 1)
> +
> static struct mfd_cell max8998_devs[] = {
> {
> .name = "max8998-pmic",
> + .name = "max8998-rtc",
> }
> };
Missing braces?
next prev parent reply other threads:[~2010-07-27 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 6:57 [PATCH 1/3] mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions Joonyoung Shim
2010-07-20 6:57 ` [PATCH 2/3] mfd: MAX8998: Add interrupts support Joonyoung Shim
2010-07-20 8:55 ` Mark Brown
2010-07-20 9:54 ` Joonyoung Shim
2010-07-25 21:52 ` Samuel Ortiz
2010-07-20 6:57 ` [PATCH 3/3] rtc: Add MAX8998 rtc driver Joonyoung Shim
2010-07-25 21:54 ` Samuel Ortiz
2010-07-27 14:52 ` Rabin Vincent [this message]
2010-07-25 21:51 ` [PATCH 1/3] mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727145247.GA23448@debian \
--to=rabin@rab.in \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gortmaker@yahoo.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox