Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if page reclaim IO is for anon or file pages

Christoph Hellwig
2010-07-19T14:15:08Z

On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote:
> It is useful to distinguish between IO for anon and file pages. This
> patch updates
> vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include
> that information. The patches can be merged together.

I think the trace would be nicer if you #define flags for both
cases and then use __print_flags on them. That'll also make it more
extensible in case we need to add more flags later.

And a purely procedural question: This is supposed to get rolled into
the original patch before it gets commited to a git tree, right?